debugwindow: update session ID tooltip #788

pull MarnixCroes wants to merge 1 commits into bitcoin-core:master from MarnixCroes:session-id-tooltip changing 1 files +1 −1
  1. MarnixCroes commented at 8:16 AM on January 17, 2024: contributor

    When you have a v2 connection, there is always a session ID.

    the if any is a leftover from #754, where the session ID property initially would always be displayed (transport v1 and v2). So the session ID could be empty when you have a v1 connection.

    As now the Session ID property only is displayed for v2 connection, there will always be a session ID.

    master

    sessionIDifany

    PR

    sessionID

    Session ID not shown when transport v1

    transportv1

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. gui: debugwindow: update session ID tooltip
    remove "if any"
    3bf00e1360
  3. DrahtBot commented at 8:16 AM on January 17, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. hebasto renamed this:
    gui: debugwindow: update session ID tooltip
    debugwindow: update session ID tooltip
    on Jan 17, 2024
  5. pablomartin4btc commented at 4:22 PM on January 25, 2024: contributor

    Concept ACK

    nit: @MarnixCroes, maybe you can add the screenshot for transport v1 and session ID is empty/ not shown, if possible, even this PR doesn't affect that logic.

  6. MarnixCroes commented at 6:11 PM on January 25, 2024: contributor

    Concept ACK

    nit: @MarnixCroes, maybe you can add the screenshot for transport v1 and session ID is empty/ not shown, if possible, even this PR doesn't affect that logic.

    done

  7. kristapsk approved
  8. kristapsk commented at 8:26 PM on January 25, 2024: contributor

    ACK 3bf00e13609eefa6ddb11353519bb1aec2342513

  9. DrahtBot requested review from pablomartin4btc on Jan 25, 2024
  10. BrandonOdiwuor commented at 7:41 AM on January 31, 2024: contributor

    Concept ACK

  11. DrahtBot removed review request from pablomartin4btc on Jan 31, 2024
  12. DrahtBot requested review from pablomartin4btc on Jan 31, 2024
  13. vostrnad commented at 7:45 AM on February 3, 2024: none

    ACK 3bf00e13609eefa6ddb11353519bb1aec2342513

  14. DrahtBot removed review request from pablomartin4btc on Feb 3, 2024
  15. DrahtBot requested review from pablomartin4btc on Feb 3, 2024
  16. DrahtBot requested review from BrandonOdiwuor on Feb 3, 2024
  17. hernanmarino approved
  18. hernanmarino commented at 1:53 AM on February 4, 2024: contributor

    Concept ACK

  19. DrahtBot removed review request from pablomartin4btc on Feb 4, 2024
  20. DrahtBot removed review request from BrandonOdiwuor on Feb 4, 2024
  21. DrahtBot requested review from pablomartin4btc on Feb 4, 2024
  22. DrahtBot requested review from BrandonOdiwuor on Feb 4, 2024
  23. jarolrod approved
  24. jarolrod commented at 10:56 PM on February 5, 2024: member

    ACK 3bf00e13609eefa6ddb11353519bb1aec2342513

  25. DrahtBot removed review request from pablomartin4btc on Feb 5, 2024
  26. DrahtBot removed review request from BrandonOdiwuor on Feb 5, 2024
  27. DrahtBot requested review from BrandonOdiwuor on Feb 5, 2024
  28. DrahtBot requested review from hernanmarino on Feb 5, 2024
  29. DrahtBot requested review from pablomartin4btc on Feb 5, 2024
  30. hebasto commented at 5:27 PM on February 7, 2024: member

    When you have a v2 connection, there is always a session ID.

    What if the connection type is still DETECTING?

    The code reference:https://github.com/bitcoin-core/gui/blob/6737331c4ccc6da578bb44c809cc4e18f017ba51/src/node/connection_types.h#L83-L88

  31. DrahtBot removed review request from BrandonOdiwuor on Feb 7, 2024
  32. DrahtBot removed review request from hernanmarino on Feb 7, 2024
  33. DrahtBot removed review request from pablomartin4btc on Feb 7, 2024
  34. DrahtBot requested review from pablomartin4btc on Feb 7, 2024
  35. DrahtBot requested review from BrandonOdiwuor on Feb 7, 2024
  36. DrahtBot requested review from hernanmarino on Feb 7, 2024
  37. MarnixCroes commented at 12:54 PM on February 8, 2024: contributor

    When you have a v2 connection, there is always a session ID.

    What if the connection type is still DETECTING?

    The code reference:

    https://github.com/bitcoin-core/gui/blob/6737331c4ccc6da578bb44c809cc4e18f017ba51/src/node/connection_types.h#L83-L88

    then there is no session ID property as it is not a v2 peer (yet), right

  38. DrahtBot removed review request from pablomartin4btc on Feb 8, 2024
  39. DrahtBot removed review request from BrandonOdiwuor on Feb 8, 2024
  40. DrahtBot removed review request from hernanmarino on Feb 8, 2024
  41. DrahtBot requested review from BrandonOdiwuor on Feb 8, 2024
  42. DrahtBot requested review from hernanmarino on Feb 8, 2024
  43. DrahtBot requested review from pablomartin4btc on Feb 8, 2024
  44. DrahtBot added the label CI failed on Feb 24, 2024
  45. DrahtBot removed the label CI failed on Feb 29, 2024
  46. pablomartin4btc approved
  47. pablomartin4btc commented at 9:49 PM on March 26, 2024: contributor

    tACK 3bf00e13609eefa6ddb11353519bb1aec2342513

    <details> <summary>Tested on Ubuntu 22.04 using <code>signet</code> (<code>./src/qt/bitcoin-qt -signet</code>) otherwise I couldn't find <code>v2</code> peers on <code>testnet</code>.</summary>

    • v2 transport with Session ID field displayed:

    image

    • v1 transport without it:

    image

    </details> [@hebasto](/bitcoin-core-gui/contributor/hebasto/) this PR only updates `peerSessionIdLabel` tooltip; this widget and the "Session ID" one, right below on the `ui` form, won't be shown on "`DETECTING`" `TransportProtocolType enum`:

    https://github.com/bitcoin-core/gui/blob/d04324a7056a735c1127ba8ccdc720a16e7281a3/src/qt/rpcconsole.cpp#L1208-L1215

  48. pablomartin4btc commented at 12:55 AM on March 27, 2024: contributor

    nit: you could expand a bit on the details of the reason of the removal of "if any" from the label in the commit body (i.e. as it's only shown in v2 transport which will always have a session id).

  49. hebasto approved
  50. hebasto commented at 6:02 PM on May 11, 2024: member

    ACK 3bf00e13609eefa6ddb11353519bb1aec2342513.

  51. hebasto merged this on May 11, 2024
  52. hebasto closed this on May 11, 2024

  53. gatleas17 commented at 1:23 AM on May 12, 2024: none

    Help!

  54. MarnixCroes deleted the branch on May 13, 2024
  55. kwvg referenced this in commit 0b80ccc10b on Oct 15, 2024
  56. kwvg referenced this in commit 525495f02c on Oct 23, 2024
  57. kwvg referenced this in commit a6f906c373 on Oct 23, 2024
  58. kwvg referenced this in commit 1efe1a54e5 on Oct 23, 2024
  59. kwvg referenced this in commit 8ce3d49fb7 on Oct 24, 2024
  60. kwvg referenced this in commit cc6b88ee37 on Oct 24, 2024
  61. PastaPastaPasta referenced this in commit 2e162da06f on Oct 24, 2024
  62. bitcoin-core locked this on May 14, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 18:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me