Fix create unsigned transaction fee bump #812

1. 
   furszy commented at 2:46 pm on March 29, 2024: member

   Fixes #810.

   Not much to explain; we were requiring the wallet to be unlocked for the unsigned transaction creation process. Fix this by moving the unlock wallet request to the signed transaction creation process.

2. gui: fix create unsigned transaction fee bump 671b7a3251
3. 
   DrahtBot commented at 2:46 pm on March 29, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	pablomartin4btc, hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. hebasto renamed this:
   gui: fix create unsigned transaction fee bump
   Fix create unsigned transaction fee bump
   on Apr 1, 2024
5. 
   pablomartin4btc commented at 2:57 am on April 2, 2024: contributor

   Concept ACK

   I’ll test it soon.

6. MarnixCroes approved
7. 
   MarnixCroes commented at 9:34 am on April 2, 2024: contributor

   tack 671b7a32516d62e1e79393ded4b45910bd08010a

   Send prompts the passphrase, Create Unsigned does not prompt the passphrase

8. in src/qt/walletmodel.cpp:546 in 671b7a3251

   542@@ -549,10 +543,15 @@ bool WalletModel::bumpFee(uint256 hash, uint256& new_hash)
   543         DataStream ssTx{};
   544         ssTx << psbtx;
   545         GUIUtil::setClipboard(EncodeBase64(ssTx.str()).c_str());
   546-        Q_EMIT message(tr("PSBT copied"), tr("Copied to clipboard", "Fee-bump PSBT saved"), CClientUIInterface::MSG_INFORMATION);
   547+        Q_EMIT message(tr("PSBT copied"), tr("Fee-bump PSBT copied to clipboard"), CClientUIInterface::MSG_INFORMATION | CClientUIInterface::MODAL);
   

   ---

   ---

   

   pablomartin4btc commented at 4:56 am on April 3, 2024:

   At least on Ubuntu 22.04, now after the fee-bumping unsigned a modal pop-up is displayed:

   

   while before there was a message sent thru the OS system information (?):

   

   I see in the code we usually use CClientUIInterface::MSG_INFORMATION (transactionview.cpp, walletview.cpp) and I’d prefer to keep this look & feel but at the same time I think having the modal window popping up it’s making the user more aware of what just happened with the intention to accept it.

   ---

   

   furszy commented at 12:37 pm on April 3, 2024:

   The change was introduced because the OS system notification wasn’t popping up on macOS. Either way is ok for me.
9. pablomartin4btc approved
10. 
    pablomartin4btc commented at 4:57 am on April 3, 2024: contributor

    tACK 671b7a32516d62e1e79393ded4b45910bd08010a

    Tested and verified this PR fixes #810 and now creation of unsigned tx/ PSBT/ during fee-bumping doesn’t ask for passphrase/ requires wallet unlock.

11. 
    maflcko commented at 7:33 am on April 18, 2024: contributor

    rfm?
12. hebasto approved
13. 
    hebasto commented at 2:27 pm on May 12, 2024: member

    ACK 671b7a32516d62e1e79393ded4b45910bd08010a, tested on Ubuntu 24.04.
14. hebasto merged this on May 12, 2024
15. hebasto closed this on May 12, 2024

    ---

16. furszy deleted the branch on May 12, 2024
17. fanquake referenced this in commit d1289a1300 on May 13, 2024
18. 
    fanquake commented at 4:23 am on May 13, 2024: member

    Backported in https://github.com/bitcoin/bitcoin/pull/30092.

Contributors
furszy DrahtBot pablomartin4btc MarnixCroes maflcko hebasto fanquake