Enable customisation of QR Code font #820

1. 
   luke-jr commented at 3:58 pm on May 11, 2024: member

   May need the fixes in #506 to work cleanly in all cases, but should still be a net improvement on its own
2. 
   DrahtBot commented at 3:58 pm on May 11, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. luke-jr renamed this:
   GUI: Enable customisation of QR Code font
   Enable customisation of QR Code font
   on May 11, 2024
4. GUI: Enable customisation of QR Code font c3bb36ad81
5. GUI: Change default QR Code font to embedded b14c9d0572
6. luke-jr force-pushed on May 16, 2024
7. DrahtBot added the label CI failed on May 16, 2024
8. 
   hebasto commented at 2:02 pm on July 15, 2024: member

   Concept ACK on adding a new customization option for the QR code font.

   Lightly tested b14c9d0572eeae0fa286e0d2b96474a6f587b18e. It seems to work as expected.

   However, I think that QR image widget must consider the font size for adjusting its own size. Otherwise, the image can be unreadable and confusing for the user:

   The second commit modifies the code introduced in the first one. Therefore, please squash them.

9. 
   DrahtBot commented at 1:42 am on October 13, 2024: contributor

   🤔 There hasn’t been much activity lately and the CI seems to be failing.

   If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn’t been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.

Contributors
luke-jr DrahtBot hebasto

Labels
CI failed