May need the fixes in #506 to work cleanly in all cases, but should still be a net improvement on its own
Enable customisation of QR Code font #820
pull luke-jr wants to merge 2 commits into bitcoin-core:master from luke-jr:qt_fontsel_qrcodes changing 7 files +86 −8-
luke-jr commented at 3:58 PM on May 11, 2024: member
-
DrahtBot commented at 3:58 PM on May 11, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers Concept ACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- luke-jr renamed this:
GUI: Enable customisation of QR Code font
Enable customisation of QR Code font
on May 11, 2024 -
GUI: Enable customisation of QR Code font c3bb36ad81
-
GUI: Change default QR Code font to embedded b14c9d0572
- luke-jr force-pushed on May 16, 2024
- DrahtBot added the label CI failed on May 16, 2024
-
hebasto commented at 2:02 PM on July 15, 2024: member
Concept ACK on adding a new customization option for the QR code font.
Lightly tested b14c9d0572eeae0fa286e0d2b96474a6f587b18e. It seems to work as expected.
However, I think that QR image widget must consider the font size for adjusting its own size. Otherwise, the image can be unreadable and confusing for the user:
The second commit modifies the code introduced in the first one. Therefore, please squash them.
-
DrahtBot commented at 1:42 AM on October 13, 2024: contributor
<!--2e250dc3d92b2c9115b66051148d6e47-->
🤔 There hasn't been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.
-
DrahtBot commented at 12:06 AM on January 11, 2025: contributor
<!--2e250dc3d92b2c9115b66051148d6e47-->
🤔 There hasn't been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.
-
DrahtBot commented at 12:55 AM on April 11, 2025: contributor
<!--2e250dc3d92b2c9115b66051148d6e47-->
🤔 There hasn't been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.
-
DrahtBot commented at 1:03 AM on July 10, 2025: contributor
<!--2e250dc3d92b2c9115b66051148d6e47-->
🤔 There hasn't been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.
- maflcko removed the label CI failed on Sep 4, 2025
-
achow101 commented at 2:30 PM on October 22, 2025: member
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.
- achow101 closed this on Oct 22, 2025
