qt6: Handle deprecated QLocale::nativeCountryName #838

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:240929-qt6-locale changing 1 files +9 −2
  1. hebasto commented at 11:14 am on September 29, 2024: member

    Split from https://github.com/bitcoin/bitcoin/pull/30997.

    QLocale::nativeCountryName() has been deprecated since Qt 6.6.

    QLocale::nativeTerritoryName() was introduced in Qt 6.2.

    This PR ensures compatibility across all supported Qt versions.

    No behaviour change for the current codebase, which uses Qt 5.


    This PR can be tested on macOS using the first commit from https://github.com/bitcoin/bitcoin/pull/30997 and Homebrew’s qt package.

  2. qt6: Handle deprecated `QLocale::nativeCountryName`
    This change ensures compatibility across all supported Qt versions.
    9123a286e9
  3. hebasto added the label Qt 6 on Sep 29, 2024
  4. DrahtBot commented at 11:14 am on September 29, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK promag, jarolrod

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. hebasto commented at 11:57 am on October 2, 2024: member
    Friendly ping @Sjors @furszy @achow101 @jarolrod ;)
  6. promag commented at 6:34 pm on October 3, 2024: contributor
    Code review ACK 9123a286e9743196307d38dd66ae0cfaf3805029.
  7. jarolrod approved
  8. jarolrod commented at 6:59 pm on October 3, 2024: member

    ACK 9123a286e9743196307d38dd66ae0cfaf3805029

    Built this on macOS with qt5.15 and Qt6.7, as well as on Linux Ubuntu with Qt6.4 and Qt6.7, and tested GUI functions related to translations.

  9. hebasto merged this on Oct 3, 2024
  10. hebasto closed this on Oct 3, 2024

  11. hebasto deleted the branch on Oct 3, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-06 05:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me