Add createwallet, createwalletdescriptor, and migratewallet to history filter #901

1. 
   waketraindev commented at 9:08 pm on October 10, 2025: contributor

   Added createwallet, createwalletdescriptor and migratewallet RPC commands to the Qt console history filter since they may include passphrases or other sensitive data that should not be stored in command history.
2. 
   DrahtBot commented at 9:09 pm on October 10, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	pablomartin4btc, hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. qt: add createwallet, createwalletdescriptor, and migratewallet to history filter 4e352efa2c
4. waketraindev force-pushed on Oct 11, 2025
5. 
   pablomartin4btc commented at 2:33 pm on October 13, 2025: contributor

   utACK 4e352efa2ce756c668664486c99d003eef530e0c

   (historyFilter was originally added in https://github.com/bitcoin/bitcoin/pull/8877)

6. in src/qt/rpcconsole.cpp:76 in 4e352efa2c

   71@@ -72,6 +72,9 @@ namespace {
   72 
   73 // don't add private key handling cmd's to the history
   74 const QStringList historyFilter = QStringList()
   75+    << "createwallet"
   76+    << "createwalletdescriptor"
   

   ---

   ---

   

   maflcko commented at 9:00 am on October 25, 2025:

   why add this, but not importdescriptors?

   ---

   

   waketraindev commented at 10:31 am on October 25, 2025:

   When I was testing this patch, I ran into some exceptions in importdescriptors related to the internal label and the range label (see bitcoin repo #31514, #32376, #33614, #33655) and the command line history was helpful for manually editing to get it to pass succesfully;

   At that point, I used #882 to manually clear the command history.

   I wasn’t sure about the commands that require a “desc” (descriptor) and allowed private ones, so I held off until I could do some manual testing.

   Potential list:

   • Have passphrase: added createwallet "wallet_name" ( disable_private_keys blank "passphrase" avoid_reuse descriptors load_on_startup external_signer ) added encryptwallet "passphrase" added migratewallet ( "wallet_name" "passphrase" ) added walletpassphrase "passphrase" timeout added walletpassphrasechange "oldpassphrase" "newpassphrase

   • Have hdkey: added createwalletdescriptor "type" ( {"internal":bool,"hdkey":"str",...} )

   • Have privatekey or privkey added signrawtransactionwithkey "hexstring" ["privatekey",...] ( [{"txid":"hex","vout":n,"scriptPubKey":"hex","redeemScript":"hex","witnessScript":"hex","amount":amount},...] "sighashtype" ) added signmessagewithprivkey "privkey" "message"

   To check which support or allow private descriptors:

   • Have desc or descriptor: deriveaddresses "descriptor" ( range ) [accepts private descriptor] getdescriptorinfo "descriptor" [accepts private descriptor] descriptorprocesspsbt "psbt" ["",{"desc":"str","range":n or [n,n]},...] ( "sighashtype" bip32derivs finalize ) [accepts private descriptor] utxoupdatepsbt "psbt" ( ["",{"desc":"str","range":n or [n,n]},...] ) [accepts private descriptor] importdescriptors requests descriptor in requests [accepts private descriptor]

   I also noticed that commands with more complex parameters or arguments (#907) can behave unexpectedly when repeated from the command line, at which point manually clearing the command history (#882) can be more practical for the user.

   I’d be happy to add importdescriptors and other suggested privacy related commands.

   Should all the commands accepting descriptor be added?

7. maflcko approved
8. 
   maflcko commented at 9:00 am on October 25, 2025: contributor

   lgtm, seems fine to add. Left a question
9. hebasto renamed this:
   qt: add createwallet, createwalletdescriptor, and migratewallet to history filter
   add createwallet, createwalletdescriptor, and migratewallet to history filter
   on Nov 3, 2025
10. hebasto renamed this:
    add createwallet, createwalletdescriptor, and migratewallet to history filter
    Add createwallet, createwalletdescriptor, and migratewallet to history filter
    on Nov 3, 2025
11. hebasto approved
12. 
    hebasto commented at 4:34 pm on November 3, 2025: member

    ACK 4e352efa2ce756c668664486c99d003eef530e0c.
13. hebasto merged this on Nov 3, 2025
14. hebasto closed this on Nov 3, 2025

    ---

15. hebasto added the label Needs release notes on Nov 3, 2025
16. waketraindev referenced this in commit afd9a9626a on Nov 4, 2025
17. 
    fanquake commented at 11:45 am on November 4, 2025: member

    Backported to 30.x in https://github.com/bitcoin/bitcoin/pull/33609.

Contributors
waketraindev DrahtBot pablomartin4btc maflcko hebasto fanquake

Labels
Needs release notes