Adds non-mempool wallet balance to overview #911

pull ajtowns wants to merge 1 commits into bitcoin-core:master from ajtowns:202511-wallet-unconf-bal-gui changing 5 files +40 −7
  1. ajtowns commented at 1:26 AM on November 19, 2025: contributor

    The wallet can contain transactions that are not accepted into the node's mempool (eg due to containing a too large OP_RETURN output, due to too low a feerate, or due to too many unconfirmed ancestors). In the event you end up in this situation, it can appear as if funds have gone missing from your wallet due to the non-mempool balance not being reported. Correct this by reporting the non-mempool balance.

    Depends on bitcoin/bitcoin#33671

  2. DrahtBot commented at 1:26 AM on November 19, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. DrahtBot added the label CI failed on Nov 19, 2025
  4. ajtowns commented at 7:06 AM on November 19, 2025: contributor

    To test, start with -datacarriersize=10, and run

    send '{"data": "4368616e63656c6c6f72206f6e206272696e6b206f66207365636f6e64206261696c6f757420666f722062616e6b73"}' null "unset" 1
    

    from the console. "Non-mempool: <change amount>" should appear in the Balances pane on the Overview window with the change from the transaction. Restarting with -datacarriersize=100000 should allow the tx to enter the mempool, and move the amount into the Available balance. (Presumably, do this on -regtest after generating 100 blocks; or perhaps signet after grabbing some funds from a faucet)

  5. ajtowns force-pushed on Nov 27, 2025
  6. ajtowns commented at 8:03 AM on November 27, 2025: contributor

    Screenshot:

    <img width="318" height="218" alt="non-mempool-gui" src="https://github.com/user-attachments/assets/885411f4-d01a-4574-a341-98b962c5c2ec" />

    The negative sign for the non-memool stuff isn't really very clear, perhaps.

  7. ajtowns force-pushed on Nov 27, 2025
  8. gui: Add non-mempool balance to wallet overview 026088b767
  9. ajtowns force-pushed on Apr 23, 2026
  10. ajtowns marked this as ready for review on Apr 23, 2026
  11. ajtowns commented at 2:41 AM on April 23, 2026: contributor

    Rebased after merge of parent PR, should be ready to review. Happy to close if some someone wants to take over.

Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-27 21:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me