Defer transaction signing until user clicks Send #915

1. 
   151henry151 commented at 7:19 pm on November 22, 2025: contributor

   Fixes #30070

   When creating an unsigned PSBT from the GUI, the transaction was already signed during preparation, causing legacy inputs to have non-empty scriptSig fields. The PSBT parser then rejects them.

   This defers signing until the user clicks “Send” instead of signing during preparation. Fee calculation still works since transactions can be created without signing.

   Follows the approach suggested by @achow101 in the issue comments.

2. qt: Defer transaction signing until user clicks Send

   Fixes #30070
   
   When creating an unsigned PSBT from the GUI, the transaction was already signed during preparation, causing legacy inputs to have non-empty scriptSig fields. The PSBT parser then rejects them.
   
   This defers signing until the user clicks "Send" instead of signing during preparation. Fee calculation still works since transactions can be created without signing.
   
   Follows the approach suggested by @achow101 in the issue comments.

   58adbcf88a
3. 
   DrahtBot commented at 7:19 pm on November 22, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #bitcoin/bitcoin/33112 (wallet: relax external_signer flag constraints by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. hebasto renamed this:
   qt: Defer transaction signing until user clicks Send
   Defer transaction signing until user clicks Send
   on Nov 22, 2025
5. DrahtBot added the label CI failed on Nov 22, 2025
6. 
   151henry151 commented at 6:02 pm on November 23, 2025: contributor

   It looks like the one failing check is a CI issue with disk space too low. I’m not sure how to address that. I think the code of the PR is correct.
7. 
   151henry151 commented at 9:51 pm on November 29, 2025: contributor

   @achow101 would you like to check this out and let me know if it looks OK?
8. maflcko closed this on Dec 17, 2025

   ---

9. maflcko reopened this on Dec 17, 2025

   ---

Contributors
151henry151 DrahtBot

Labels
CI failed