move-only: MAX_BLOCK_TIME_GAP to src/qt #919

1. 
   maflcko commented at 12:56 pm on December 17, 2025: contributor

   MAX_BLOCK_TIME_GAP was used in some incorrect heuristics, which were removed in commit e30b6ea194fee3bb95a45e7b732a99566b88f1f5.

   This leaves a single module in src/qt using the constant.

   Instead of exposing it in a central kernel header, just move it to the single gui module that uses it.

2. move-only: MAX_BLOCK_TIME_GAP to src/qt

   Can be reviewed via the git option:
   --color-moved=dimmed-zebra

   fa5ed16aa4
3. 
   DrahtBot commented at 12:56 pm on December 17, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sedited, hebasto

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

4. 
   fanquake commented at 1:17 pm on December 17, 2025: member

   cc @sedited
5. sedited approved
6. 
   sedited commented at 1:43 pm on December 17, 2025: contributor

   ACK fa5ed16aa4d9dbe3ed47cb53f3cb15b0685a2b96

   Seems appropriate to move this.

7. DrahtBot added the label CI failed on Dec 17, 2025
8. 
   maflcko commented at 5:03 pm on December 17, 2025: contributor

   Looks like the valgrind fuzz times out, but this seems unrelated. Probably needs the timeout bumped.
9. hebasto approved
10. 
    hebasto commented at 5:09 pm on December 17, 2025: member

    ACK fa5ed16aa4d9dbe3ed47cb53f3cb15b0685a2b96, I have reviewed the code and it looks OK.
11. hebasto merged this on Dec 17, 2025
12. hebasto closed this on Dec 17, 2025

    ---

13. maflcko deleted the branch on Dec 17, 2025

Contributors
maflcko DrahtBot fanquake sedited hebasto

Labels
CI failed