Show an error message if the restored wallet name is empty #924

pull achow101 wants to merge 1 commits into bitcoin-core:master from achow101:gui-unnamed-restore-error-dialog changing 1 files +5 −1
  1. achow101 commented at 11:45 pm on January 12, 2026: member
    The Restore Wallet dialog rejects wallet names that are empty, but was doing so silently. This is confusing, we should be presenting an error message to the user.
  2. gui: Show an error message if the restored wallet name is empty
    The Restore Wallet dialog rejects wallet names that are empty, but was
    doing so silently. This is confusing, we should be presenting an error
    message to the user.
    dd904298c1
  3. DrahtBot commented at 11:46 pm on January 12, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  4. DrahtBot added the label CI failed on Jan 13, 2026
  5. polespinasa approved
  6. polespinasa commented at 12:35 pm on January 13, 2026: member

    Code review and tested ack dd904298c13b14ef518e24fa63c6d0962f4a2de0

    Tested the current (master) version and it’s pretty annoying that the retire wallet screen just closes if the name is empty. Now the message is pretty clear.

  7. hebasto renamed this:
    gui: Show an error message if the restored wallet name is empty
    Show an error message if the restored wallet name is empty
    on Jan 17, 2026
  8. hebasto approved
  9. hebasto commented at 9:48 am on January 17, 2026: member
    ACK dd904298c13b14ef518e24fa63c6d0962f4a2de0. Tested on Fedora 43.
  10. hebasto merged this on Jan 17, 2026
  11. hebasto closed this on Jan 17, 2026

  12. hebasto commented at 10:07 am on January 17, 2026: member

    @fanquake

    Backport to all maintained branches?


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-28 00:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me