The Restore Wallet dialog rejects wallet names that are empty, but was doing so silently. This is confusing, we should be presenting an error message to the user.
Show an error message if the restored wallet name is empty #924
pull achow101 wants to merge 1 commits into bitcoin-core:master from achow101:gui-unnamed-restore-error-dialog changing 1 files +5 −1-
achow101 commented at 11:45 PM on January 12, 2026: member
-
dd904298c1
gui: Show an error message if the restored wallet name is empty
The Restore Wallet dialog rejects wallet names that are empty, but was doing so silently. This is confusing, we should be presenting an error message to the user.
-
DrahtBot commented at 11:46 PM on January 12, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label CI failed on Jan 13, 2026
- polespinasa approved
-
polespinasa commented at 12:35 PM on January 13, 2026: member
Code review and tested ack dd904298c13b14ef518e24fa63c6d0962f4a2de0
Tested the current (master) version and it's pretty annoying that the retire wallet screen just closes if the name is empty. Now the message is pretty clear.
<img width="536" height="532" alt="Image" src="https://github.com/user-attachments/assets/5fd9b949-e106-4d6f-a2d0-fdb47ac49483" />
- hebasto renamed this:
gui: Show an error message if the restored wallet name is empty
Show an error message if the restored wallet name is empty
on Jan 17, 2026 - hebasto approved
-
hebasto commented at 9:48 AM on January 17, 2026: member
ACK dd904298c13b14ef518e24fa63c6d0962f4a2de0. Tested on Fedora 43.
- hebasto merged this on Jan 17, 2026
- hebasto closed this on Jan 17, 2026
-
Contributors
Labels