Remove opt-in RBF #936

pull polespinasa wants to merge 1 commits into bitcoin-core:master from polespinasa:2026-05-05-remove-optinRBF changing 4 files +8 −39

polespinasa commented at 3:10 PM on May 5, 2026: member

With the whole network mostly running with Full Replace By Fee, it does not make sense to let the user signal or not to signal for RBF on their transactions.

With this PR the transactions created using the GUI will fallback to the wallet configuration in order to signal or not to signal BIP 125. (True by default).
DrahtBot commented at 3:10 PM on May 5, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK sedited

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Type	Reviewers
ACK	sedited

in src/qt/sendcoinsdialog.cpp:367 in db677efbde outdated

 349 | @@ -360,15 +350,6 @@ bool SendCoinsDialog::PrepareSendText(QString& question_string, QString& informa
 350 |          question_string.append("<span style='color:#aa0000; font-weight:bold;'>");
 351 |          question_string.append(BitcoinUnits::formatHtmlWithUnit(model->getOptionsModel()->getDisplayUnit(), txFee));
 352 |          question_string.append("</span><br />");
 353 | -
 354 | -        // append RBF message according to transaction's signalling
 355 | -        question_string.append("<span style='font-size:10pt; font-weight:normal;'>");
 356 | -        if (ui->optInRBF->isChecked()) {
 357 | -            question_string.append(tr("You can increase the fee later (signals Replace-By-Fee, BIP-125)."));

sedited commented at 4:55 PM on May 11, 2026:

Might be good to keep the "You can increase the fee later" string?

polespinasa commented at 6:46 PM on May 13, 2026:

Yes, makes sens, added back.

polespinasa force-pushed on May 13, 2026

Remove opt-in RBF

Remove the option to signal or not signal for BIP 125 (Opt-in Full Replace-By-Fee).
By removing the option in the GUI it will fallback to the wallet configuration which by default is
true unless the user changed it using CLI.

90eda67bb8

polespinasa force-pushed on May 13, 2026
DrahtBot added the label CI failed on May 13, 2026
sedited approved
sedited commented at 6:53 PM on May 13, 2026: contributor

ACK 90eda67bb8f9c3b82a3eccc787446269c83b2558
polespinasa commented at 9:43 PM on May 13, 2026: member

Failing test seems unrelated
in src/qt/sendcoinsdialog.cpp:357 in 90eda67bb8
```
 361 | -        question_string.append("</span>");
 362 |      }
 363 |  
 364 | +    // append RBF message
 365 | +    question_string.append("<span style='font-size:10pt; font-weight:normal;'>");
 366 | +    question_string.append(tr("You can increase the fee later."));
```
hebasto commented at 10:39 AM on May 14, 2026:

What if Bitcoin Core is run with -walletrbf=0?

polespinasa commented at 10:48 AM on May 14, 2026:

Have to test to ensure there's no random check that blocks the transaction from being broadcasted but it is redundant.

Anyway there is work ongoing towards deprecating and removing it. https://github.com/bitcoin/bitcoin/pull/34917
hebasto commented at 10:42 AM on May 14, 2026: member

Is the "RPC only" note still correct here:https://github.com/bitcoin-core/gui/blob/cad5f5604582eac95bcfbf08cca8af1c186c36eb/src/wallet/init.cpp#L77?
polespinasa commented at 10:50 AM on May 14, 2026: member

Is the "RPC only" note still correct here

Not at all. If this gets merged I can open a follow-up PR to change that line, maybe can just ask to get it modified here https://github.com/bitcoin/bitcoin/pull/34917. Happens when repos are split 🤷‍♂️

Contributors

Labels

Remove opt-in RBF #936

Reviews