GUI/Intro: Skip intro dialog when -blocksdir is manually passed #948

pull diegoviola wants to merge 1 commits into bitcoin-core:master from diegoviola:intro-blocksdir-fix changing 1 files +2 −0
  1. diegoviola commented at 2:10 PM on July 16, 2026: contributor

    Fixes: #946

  2. GUI/Intro: Skip intro dialog when -blocksdir is manually passed
    Fixes: #946
    282b7a50c7
  3. DrahtBot commented at 2:10 PM on July 16, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    Concept ACK pablomartin4btc

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. pablomartin4btc commented at 6:01 PM on July 16, 2026: contributor

    Concept ACK

    The actual problem in #946 is the intro dialog's prune suggestion (only shown the first time bitcoin-qt runs) — FreespaceChecker checks datadir's free space but the prune trigger uses the full blockchain + chainstate threshold (~880 GB), incorrectly suggesting prune when -blocksdir is set since only ~14 GB of chainstate goes to datadir. Skipping the dialog avoids the wrong suggestion.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-07-19 05:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me