GUI/Intro: pass -blocksdir to getPathToCheck if present #948

1. 
   diegoviola commented at 2:10 PM on July 16, 2026: contributor

   Fixes: #946

2. 
   DrahtBot commented at 2:10 PM on July 16, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline and AI policy for information on the review process.

   Type	Reviewers
   Concept ACK	pablomartin4btc

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

3. 
   pablomartin4btc commented at 6:01 PM on July 16, 2026: contributor

   Concept ACK

   The actual problem in #946 is the intro dialog's prune suggestion (only shown the first time bitcoin-qt runs) — FreespaceChecker checks datadir's free space but the prune trigger uses the full blockchain + chainstate threshold (~880 GB), incorrectly suggesting prune when -blocksdir is set since only ~14 GB of chainstate goes to datadir. Skipping the dialog avoids the wrong suggestion.

4. 
   hebasto commented at 11:42 AM on August 16, 2026: member

   I'm not sure this is the correct approach.

   For example, it breaks the -choosedatadir option, which is now ignored when combined with -blocksdir:

   $ ./build_dev_mode/bin/bitcoin-qt -choosedatadir -blocksdir=/tmp/test_blocksdir
   # no intro dialog is shown
   

5. diegoviola force-pushed on Aug 19, 2026
6. diegoviola requested review from pablomartin4btc on Aug 19, 2026
7. diegoviola requested review from hebasto on Aug 19, 2026
8. GUI/Intro: pass -blocksdir to getPathToCheck if present

   Fixes: #946

   1ce7bdca77
9. diegoviola force-pushed on Aug 19, 2026
10. diegoviola renamed this:
    GUI/Intro: Skip intro dialog when -blocksdir is manually passed
    GUI/Intro: pass -blocksdir to getPathToCheck if present
    on Aug 19, 2026
11. DrahtBot added the label CI failed on Aug 19, 2026
12. 
    diegoviola commented at 4:12 AM on August 19, 2026: contributor

    I'm not sure this is the correct approach.

    For example, it breaks the -choosedatadir option, which is now ignored when combined with -blocksdir:

    $ ./build_dev_mode/bin/bitcoin-qt -choosedatadir -blocksdir=/tmp/test_blocksdir
    # no intro dialog is shown
    

    Can you please try this new approach? The dialog is now being shown for me and prune is disabled when running ./bin/bitcoin-qt -choosedatadir -blocksdir=/path/to/bitcoin-blocks/ which I think is the correct behavior.

13. DrahtBot removed the label CI failed on Aug 19, 2026

Contributors

diegoviolaDrahtBotpablomartin4btchebasto

Review Requested
hebastopablomartin4btc