Add code comments and documentation. Most of these comments were originally added as part of #94 but are being moved to a separate PR so they can be merged sooner
doc: Add various code comments and documentation #100
pull ryanofsky wants to merge 7 commits into bitcoin-core:master from ryanofsky:pr/mdoc changing 2 files +142 −18-
ryanofsky commented at 12:57 PM on June 13, 2024: collaborator
-
doc: Add comments to mp.Context PassField function on mp.Context.thread lookup e49a925a40
-
doc: Add comments to mp.Context PassField function on updating g_thread_context a1dfb0bab4
-
doc: Add comment on serverInvoke ReplaceVoid usage 2098ae1b18
-
e99c0b7564
doc: Document clientInvoke/serverInvoke functions
Show how they are invoked by generated code
-
doc: Document ProxyClient construct/destroy methods 78c7dd0be5
-
doc: Document FunctionTraits/ProxyMethodTraits classes d4d9f93175
-
537c645652
doc: Improve ProxyServerCustom class documentation
Add note about cleaning up custom state asynchronously, after a recently fixed bug where there was a wallet deadlock when the node connection was broken, caused by the ProxyServerCustom<WalletLoader> destructor trying to delete the wallet CScheduler object synchronously (on the IPC EventLoop thread) while a scheduled task was trying to make an Chain isReadyToBroadcast() IPC call.
- ryanofsky force-pushed on Jun 13, 2024
-
ryanofsky commented at 3:19 PM on June 13, 2024: collaborator
Updated efe42cc2879915b2ffdff04ec1cfe715e8dfa0a0 -> fce859d5d27c5c3843f3d456aa6d2e4aa114f196 (
pr/mdoc.1->pr/mdoc.2, compare) improving the documentation. Updated fce859d5d27c5c3843f3d456aa6d2e4aa114f196 -> 537c645652cb98a641bb7e40ff541c89bf4ec471 (pr/mdoc.2->pr/mdoc.3, compare) with more tweaks. - ryanofsky force-pushed on Jun 13, 2024
- ryanofsky merged this on Jun 13, 2024
- ryanofsky closed this on Jun 13, 2024
- ryanofsky referenced this in commit 8da0524628 on Jun 13, 2024
- ryanofsky referenced this in commit 3e6c61fdc2 on Jun 13, 2024
- ryanofsky referenced this in commit eecd63c8e2 on Jul 11, 2024
- ryanofsky referenced this in commit e58937ea45 on Jul 12, 2024
- ryanofsky referenced this in commit 48a2fc6fb1 on Jul 16, 2024
- ryanofsky referenced this in commit 8574f79db9 on Jul 16, 2024
- Sjors referenced this in commit c2dbbc5fb7 on Jul 17, 2024
- Sjors referenced this in commit fa0a0fa537 on Jul 17, 2024
- Sjors referenced this in commit 10100360b6 on Jul 18, 2024
- Sjors referenced this in commit 39c615dbdc on Jul 18, 2024
- ryanofsky referenced this in commit 33e86e04d1 on Jul 18, 2024
- ryanofsky referenced this in commit b3a5eb738f on Jul 18, 2024
- Sjors referenced this in commit 3cfcac15ba on Jul 19, 2024
- ryanofsky referenced this in commit 261395944e on Jul 24, 2024
- ryanofsky referenced this in commit c030548f20 on Jul 26, 2024
- ryanofsky referenced this in commit ebe93a5d0a on Sep 26, 2024
- bitcoin-core locked this on Jun 25, 2025