Problem was pointed out by TheCharlatan in https://github.com/chaincodelabs/libmultiprocess/pull/107#issuecomment-2301338227
example: Add missing thread.join() call so example can exit cleanly #109
pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/bye changing 1 files +4 −1-
ryanofsky commented at 2:21 PM on August 21, 2024: collaborator
-
70b2d8794f
example: Add missing thread.join() call so example can exit cleanly
Problem was pointed out by TheCharlatan <seb.kung@gmail.com> in https://github.com/chaincodelabs/libmultiprocess/pull/107#issuecomment-2301338227
- TheCharlatan approved
-
TheCharlatan commented at 2:31 PM on August 21, 2024: collaborator
ACK 70b2d8794f3b78c2028dd6e8d00444b178e76893
I tried adding
thread.join()too before, but forgot to apply my prior patch and it never exited, because it still had a client. Thank you! - ryanofsky merged this on Aug 21, 2024
- ryanofsky closed this on Aug 21, 2024
- ryanofsky referenced this in commit 357a6bc97b on Sep 9, 2024
- ryanofsky referenced this in commit 210700f319 on Sep 10, 2024
- ryanofsky referenced this in commit 587c019b38 on Sep 10, 2024
- Sjors referenced this in commit dbd15b6b1f on Sep 10, 2024
- Sjors referenced this in commit 979b94a90d on Sep 11, 2024
- Sjors referenced this in commit a438912388 on Sep 11, 2024
- ryanofsky referenced this in commit 3d954627d9 on Sep 17, 2024
- ryanofsky referenced this in commit 2348596587 on Sep 17, 2024
- ryanofsky referenced this in commit 8c2dd0426a on Sep 19, 2024
- ryanofsky referenced this in commit 72689b19db on Sep 19, 2024
- Sjors referenced this in commit 7c99b034c1 on Sep 19, 2024
- Sjors referenced this in commit 3780057949 on Sep 19, 2024
- Sjors referenced this in commit 94aa5d0b3d on Sep 20, 2024
- ryanofsky referenced this in commit 287eafc66b on Sep 24, 2024
- ryanofsky referenced this in commit 070e6a32d5 on Sep 24, 2024
- m3dwards referenced this in commit 426ecb8483 on Oct 3, 2024
- janus referenced this in commit 2864e7638f on Jan 19, 2025
- bitcoin-core locked this on Aug 21, 2025
Contributors