Add missing include to util.h #113

pull fanquake wants to merge 1 commits into bitcoin-core:master from fanquake:fix_missing_include changing 1 files +1 −0
  1. fanquake commented at 9:26 AM on September 27, 2024: member

    Fixes:

    mp/util.h:207:20: error: no template named 'function' in namespace 'std'; did you mean 'kj::Function'?
      207 | using FdToArgsFn = std::function<std::vector<std::string>(int fd)>;
          |                    ^~~~~~~~~~~~~
          |                    kj::Function
    

    when compiling with libc++ & _LIBCPP_REMOVE_TRANSITIVE_INCLUDES.

  2. Add missing include to util.h
    Fixes:
    ```bash
    mp/util.h:207:20: error: no template named 'function' in namespace 'std'; did you mean 'kj::Function'?
      207 | using FdToArgsFn = std::function<std::vector<std::string>(int fd)>;
          |                    ^~~~~~~~~~~~~
          |                    kj::Function
    ```
    when compiling with libc++ & `_LIBCPP_REMOVE_TRANSITIVE_INCLUDES`.
    6929c40913
  3. hebasto approved
  4. hebasto commented at 11:24 AM on September 27, 2024: member

    ACK 6929c40913ce2bbee58754f2984ddd7ec97b44ea, tested on Ubuntu 23.10 by building Bitcoin Core with depends using the following patch:

    --- a/depends/packages/native_libmultiprocess.mk
    +++ b/depends/packages/native_libmultiprocess.mk
    @@ -1,8 +1,8 @@
     package=native_libmultiprocess
    -$(package)_version=015e95f7ebaa47619a213a19801e7fffafc56864
    -$(package)_download_path=https://github.com/chaincodelabs/libmultiprocess/archive
    +$(package)_version=6929c40913ce2bbee58754f2984ddd7ec97b44ea
    +$(package)_download_path=https://github.com/fanquake/libmultiprocess/archive
     $(package)_file_name=$($(package)_version).tar.gz
    -$(package)_sha256_hash=4b1266b121337f3f6f37e1863fba91c1a5ee9ad126bcffc6fe6b9ca47ad050a1
    +$(package)_sha256_hash=e0aab3166ca902e7b255b4e1766c71c5e99170534ae412136e4133d4f85745d7
     $(package)_dependencies=native_capnp
     
     define $(package)_config_cmds
    

    and the following command:

    $ make -C depends CC="clang" CXX="clang++ -stdlib=libc++" CPPFLAGS="-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES" MULTIPROCESS=1 libmultiprocess
    
  5. ryanofsky commented at 1:02 PM on September 30, 2024: collaborator

    Code review ACK 6929c40913ce2bbee58754f2984ddd7ec97b44ea, thanks for the fix

  6. ryanofsky merged this on Sep 30, 2024
  7. ryanofsky closed this on Sep 30, 2024

  8. Sjors referenced this in commit fd53ceb460 on Oct 1, 2024
  9. Sjors referenced this in commit 2a4c0e8dad on Oct 4, 2024
  10. Sjors referenced this in commit 7ad85d40e8 on Oct 4, 2024
  11. Sjors referenced this in commit a5ea996cdf on Oct 5, 2024
  12. Sjors referenced this in commit 9b1bdabe9c on Oct 7, 2024
  13. ryanofsky referenced this in commit 965838b65f on Oct 8, 2024
  14. ryanofsky referenced this in commit 41d94fa0c3 on Oct 8, 2024
  15. ryanofsky referenced this in commit 90b405516f on Oct 16, 2024
  16. fanquake referenced this in commit 563c4d2926 on Oct 21, 2024
  17. janus referenced this in commit eb4d842678 on Jan 19, 2025
  18. bitcoin-core locked this on Sep 30, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 19:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me