ci: Add NetBSD job

hebasto commented at 1:19 pm on August 23, 2025: member

The master branch @ 1b8d4a6f1e54b92708bd2ad627ec6d440a1daf3d fails to build on NetBSD.

See: https://github.com/hebasto/libmultiprocess/actions/runs/17175941246/job/48731811650

DrahtBot commented at 1:19 pm on August 23, 2025: none

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

hebasto referenced this in commit ff81a4a623 on Aug 23, 2025

hebasto referenced this in commit cc1420b806 on Aug 23, 2025

in .github/workflows/ci.yml:18 in 4c0665854f outdated

13+        shell: netbsd {0}
14+    steps:
15+      - uses: actions/checkout@v5
16+
17+      - name: Start NetBSD VM
18+        uses: vmactions/netbsd-vm@v1

hebasto commented at 1:34 pm on August 23, 2025:

@ryanofsky

Could you please enable this action in the repo settings?

ryanofsky commented at 1:44 pm on August 23, 2025:

@ryanofsky

Could you please enable this action in the repo settings?

Thanks! Should be enabled now

hebasto commented at 1:52 pm on August 23, 2025:

For some reason it still complains:

0The action vmactions/netbsd-vm@v1 is not allowed in bitcoin-core/libmultiprocess because all actions must be from a repository owned by bitcoin-core or match one of the patterns: actions/checkout@*, cachix/install-nix-action@*, vmactions/openbsd-vm@*.

ryanofsky commented at 4:19 pm on August 23, 2025:

For some reason it still complains:

Looks like the value was not updated, should be fixed now

hebasto force-pushed on Aug 23, 2025

ryanofsky commented at 1:48 pm on August 23, 2025: collaborator

Errors all appear to be undefined reference to 'kj::getCaughtExceptionAsKj()' linker errors

hebasto closed this on Aug 23, 2025

hebasto reopened this on Aug 23, 2025

ryanofsky commented at 2:01 pm on August 23, 2025: collaborator

I noticed getCaughtExceptionAsKj doesn’t seem to be defined if KJ_NO_EXCEPTIONS is defined. Doesn’t look like netbsd is defining that though https://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/capnproto/

ryanofsky closed this on Aug 23, 2025

ryanofsky reopened this on Aug 23, 2025

in .github/workflows/ci.yml:27 in 5852983f42 outdated

22+          sync: 'rsync'
23+          copyback: false
24+
25+      - name: Run CI script
26+        run: |
27+          cd ${{ github.workspace }}

maflcko commented at 9:04 am on August 24, 2025:

nit: Could address #195 (review) while touching this file?

hebasto commented at 10:46 am on August 24, 2025:

nit: Could address #195 (comment) while touching this file?

Responded here.

UPD. If this line is dropped, the job fails:

0bash: ci/scripts/ci.sh: No such file or directory

Sjors commented at 7:40 am on September 5, 2025: member

Maybe rebase after #197 for easier review?

ci: Add NetBSD job

Add `pkg-config` package

e0c1fb050e

hebasto force-pushed on Sep 5, 2025

hebasto commented at 2:14 pm on September 5, 2025: member

Maybe rebase after #197 for easier review?

Sure! Rebased.

ryanofsky commented at 2:35 pm on September 5, 2025: collaborator

Assuming the netbsd job still fails, I guess there are different directions we may go with this issue:

If it’s possible to fix this with a change in libmultiprocess that would be ideal.
If that’s not possible, then maybe netbsd job could install from capnproto from source and we could report an issue to netbsd.
If installing capnproto from source doesn’t work, this will require a fix in capnproto.

And regardless of these, we may want to add a try_compile test and error with suggested workarounds along the lines of #205

hebasto commented at 2:42 pm on September 5, 2025: member

Assuming the netbsd job still fails, I guess there are different directions we may go with this issue:

If it’s possible to fix this with a change in libmultiprocess that would be ideal.

If that’s not possible, then maybe netbsd job could install from capnproto from source and we could report an issue to netbsd.

If installing capnproto from source doesn’t work, this will require a fix in capnproto.

And regardless of these, we may want to add a try_compile test and error with suggested workarounds along the lines of #205

FWIW, build with depends succeeds: https://github.com/hebasto/bitcoin-core-nightly/actions/runs/17482518540/job/49655572035.

ci: Add NetBSD job #196

Reviews