ci: Add freebsd and macos build #197

maflcko commented at 8:28 AM on August 26, 2025: contributor

Should be harmless to add and may be useful

DrahtBot commented at 8:28 AM on August 26, 2025: none

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, ryanofsky, Sjors

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

maflcko renamed this:
~~ci: Add freebsd build~~
ci: Add freebsd and macos build
on Aug 26, 2025

maflcko force-pushed on Aug 26, 2025

in .github/workflows/ci.yml:47 in a504a4c03f outdated

  42 | +        shell: freebsd {0}
  43 | +    steps:
  44 | +      - uses: actions/checkout@v5
  45 | +
  46 | +      - name: Start FreeBSD VM
  47 | +        uses: vmactions/freebsd-vm@v1

hebasto commented at 7:16 AM on August 29, 2025:

@ryanofsky

Could you please enable this action in the repo?

maflcko commented at 7:33 AM on August 29, 2025:

might as well enable all vmactions/*? I don't plan to add more, but there is another pull about netbsd. Also, if one action was backdoored, enabling more should be harmless.

ryanofsky commented at 1:44 PM on September 2, 2025:

re: #197 (review)

might as well enable all vmactions/*? I don't plan to add more, but there is another pull about netbsd. Also, if one action was backdoored, enabling more should be harmless.

Makes sense. vmactions/*is enabled now

in .github/workflows/ci.yml:21 in a504a4c03f outdated

  17 | @@ -18,7 +18,7 @@ jobs:
  18 |          uses: vmactions/openbsd-vm@v1
  19 |          with:
  20 |            prepare: |
  21 | -            pkg_add -v cmake ninja git python bash
  22 | +            pkg_add -v cmake ninja git bash

hebasto commented at 7:19 AM on August 29, 2025:

Right. I noticed this excess package while working on #196.

Sjors commented at 8:11 AM on September 1, 2025: member

Concept ACK

This may also help debug why (so far) I haven't been able to run the nix based tests on macOS.

maflcko commented at 8:34 AM on September 1, 2025: contributor

This may also help debug why (so far) I haven't been able to run the nix based tests on macOS.

The CI task added here isn't using nix on macos. It is certainly possible to do so, see https://github.com/maflcko/libmultiprocess/actions/runs/17243581016/job/48927248082 / e8dc12dea22c102ee83bc23cb584cb9096fbee43. However:

Nix seems more niche on macos and users are more likely to use brew?
Nix takes a longer time than brew, because the setup is more involved and taking a longer time.

No strong opinion, but happy to adjust, if there are reasons to do so.

Sjors commented at 8:46 AM on September 1, 2025: member

Nix seems more niche on macos and users are more likely to use brew

That's probably true.

It seems useful to test on macOS without nix.

ryanofsky closed this on Sep 2, 2025

ryanofsky reopened this on Sep 2, 2025

ci: Add macos and freebsd task

Also, remove unused python from install.

fa1ac30000

in .github/workflows/ci.yml:70 in a504a4c03f outdated

  65 | +
  66 | +      - name: Install dependencies
  67 | +        env:
  68 | +          HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1
  69 | +        run: |
  70 | +          brew install --quiet cmake ninja capnp

hebasto commented at 2:33 PM on September 2, 2025:

https://github.com/bitcoin-core/libmultiprocess/actions/runs/17405522020/job/49408698426:

Error: cmake was installed from the local/pinned tap
but you are trying to install it from the homebrew/core tap.
Formulae with the same name from different taps cannot be installed at the same time.

maflcko commented at 2:59 PM on September 2, 2025:

thx, removed

maflcko force-pushed on Sep 2, 2025

hebasto approved

hebasto commented at 3:04 PM on September 2, 2025: member

ACK fa1ac300005530d4a9e816234df50abeaf6ddcd4.

ryanofsky approved

ryanofsky commented at 8:17 PM on September 3, 2025: collaborator

Code review ACK fa1ac300005530d4a9e816234df50abeaf6ddcd4. Seems good to cover these different package managers and platforms

in .github/workflows/ci.yml:74 in fa1ac30000

  69 | +        run: |
  70 | +          brew install --quiet ninja capnp
  71 | +
  72 | +      - name: Run CI script
  73 | +        run: |
  74 | +          CI_CONFIG="ci/configs/macos.bash" bash ci/scripts/ci.sh

Sjors commented at 7:21 AM on September 4, 2025:

I tested that this also works locally on macOS.

DrahtBot requested review from Sjors on Sep 4, 2025

Sjors commented at 7:22 AM on September 4, 2025: member

ACK fa1ac300005530d4a9e816234df50abeaf6ddcd4

ryanofsky merged this on Sep 4, 2025

ryanofsky closed this on Sep 4, 2025

maflcko deleted the branch on Sep 4, 2025

ryanofsky referenced this in commit a334bbe9b7 on Sep 5, 2025

fanquake referenced this in commit 9c6fa07b12 on Sep 8, 2025

Sjors referenced this in commit 132621fc01 on Sep 23, 2025