ci: suppress two tidy lint issues #244

pull Sjors wants to merge 2 commits into bitcoin-core:master from Sjors:2026/02/lint changing 2 files +2 −2
  1. Sjors commented at 5:22 pm on February 24, 2026: member
    Needed for clang-22 tidy job, see: https://github.com/bitcoin/bitcoin/pull/34662
  2. DrahtBot commented at 5:22 pm on February 24, 2026: none

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK ryanofsky

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  3. Sjors force-pushed on Feb 24, 2026
  4. Sjors renamed this:
    ipc: suppress nontrivial-threadlocal lint in proxy.cpp
    ci: suppress two tidy lint issues
    on Feb 24, 2026
  5. ryanofsky commented at 10:19 am on February 25, 2026: collaborator
    Code review ACK bc2c12ecfe88a9c79633e2ce46f638993007633a. I do think it’d be good to drop // NOLINT(bugprone-unused-return-value) and use (void) instead, and am pretty sure that should be sufficient for https://github.com/bitcoin/bitcoin/pull/34662#discussion_r2848564166 but we can see. Planning to hold off merging for now until there’s an update.
  6. fanquake commented at 10:21 am on February 25, 2026: member
  7. ci: suppress nontrivial-threadlocal lint in proxy.cpp
    Needed for clang-22 tidy job, see:
    https://github.com/bitcoin/bitcoin/pull/34662
    
    Co-authored-by: fanquake <fanquake@gmail.com>
    dacd5eda46
  8. ci: avoid bugprone-unused-return-value lint in test
    Needed for clang-22 tidy job, see:
    https://github.com/bitcoin/bitcoin/pull/34662
    
    Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
    16dfc36864
  9. Sjors force-pushed on Feb 25, 2026
  10. Sjors commented at 3:13 pm on February 25, 2026: member
    Switched to void.
  11. ryanofsky approved
  12. ryanofsky commented at 4:07 pm on February 25, 2026: collaborator
    Code review ACK 16dfc3686401b1f6a4f7eff62e6f8038e6acffc1, just switching to NOLINT to (void) since last
  13. ryanofsky merged this on Feb 25, 2026
  14. ryanofsky closed this on Feb 25, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-09 11:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me