Needed for clang-22 tidy job, see: https://github.com/bitcoin/bitcoin/pull/34662
ci: suppress two tidy lint issues #244
pull Sjors wants to merge 2 commits into bitcoin-core:master from Sjors:2026/02/lint changing 2 files +2 −2-
Sjors commented at 5:22 PM on February 24, 2026: member
-
DrahtBot commented at 5:22 PM on February 24, 2026: none
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK ryanofsky If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- Sjors force-pushed on Feb 24, 2026
- Sjors renamed this:
ipc: suppress nontrivial-threadlocal lint in proxy.cpp
ci: suppress two tidy lint issues
on Feb 24, 2026 -
ryanofsky commented at 10:19 AM on February 25, 2026: collaborator
Code review ACK bc2c12ecfe88a9c79633e2ce46f638993007633a. I do think it'd be good to drop
// NOLINT(bugprone-unused-return-value)and use(void)instead, and am pretty sure that should be sufficient for https://github.com/bitcoin/bitcoin/pull/34662#discussion_r2848564166 but we can see. Planning to hold off merging for now until there's an update. -
fanquake commented at 10:21 AM on February 25, 2026: member
Using
(void)should be fine here: https://github.com/bitcoin/bitcoin/actions/runs/22391846665/job/64815578079?pr=34662. -
dacd5eda46
ci: suppress nontrivial-threadlocal lint in proxy.cpp
Needed for clang-22 tidy job, see: https://github.com/bitcoin/bitcoin/pull/34662 Co-authored-by: fanquake <fanquake@gmail.com>
-
16dfc36864
ci: avoid bugprone-unused-return-value lint in test
Needed for clang-22 tidy job, see: https://github.com/bitcoin/bitcoin/pull/34662 Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
- Sjors force-pushed on Feb 25, 2026
-
Sjors commented at 3:13 PM on February 25, 2026: member
Switched to void.
- ryanofsky approved
-
ryanofsky commented at 4:07 PM on February 25, 2026: collaborator
Code review ACK 16dfc3686401b1f6a4f7eff62e6f8038e6acffc1, just switching to NOLINT to (void) since last
- ryanofsky merged this on Feb 25, 2026
- ryanofsky closed this on Feb 25, 2026
