Running clang-tidy on macos I get this error:
0/Users/matthewzipkin/Desktop/work/bitcoin/src/ipc/libmultiprocess/src/mp/util.cpp:84:25: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
1 84 | pthread_threadid_np(NULL, &tid);
2 | ^~~~
3 | nullptr
I suspect the reason this hasn’t triggered failures on our CI is that this code block is not compiled on linux:
Simple!
brew install llvm:
0--> which clang-tidy
1/opt/homebrew/Cellar/llvm/22.1.1/bin/clang-tidy
2--> clang-tidy --version
3Homebrew LLVM version 22.1.1
4 Optimized build.
Modified some code from bitcoin core ci/test/03_test_script.sh and added to .bash_profile:
0bctidy(){
1 cd /Users/matthewzipkin/Desktop/work/bitcoin
2 cmake -B build_tidy -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
3 cmake --build build_tidy -j 8
4
5 set -eo pipefail
6 (
7 cd ./src/ &&
8 if ! ( PYTHONUNBUFFERED=1 run-clang-tidy -p ../build_tidy -quiet -config-file=.clang-tidy -j 8 | tee ../build_tidy/tidy-out.txt ); then
9 echo
10 echo "Failure generated from clang-tidy:"
11 grep -C5 "error: " ../build_tidy/tidy-out.txt
12 fi
13 )
14}