ci: enable clang-tidy in macOS job, use nullptr #262

The first commit reproduces #261:

/Users/runner/work/libmultiprocess/libmultiprocess/src/mp/util.cpp:84:25: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
   84 |     pthread_threadid_np(NULL, &tid);
      |                         ^~~~
      |                         nullptr
2 warnings generated.
Suppressed 1 warnings (1 in non-user code).
Use -header-filter=.* or leave it as default to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error

https://github.com/bitcoin-core/libmultiprocess/actions/runs/23348264051/job/67919536711?pr=262

Using clang-tidy in the macOS job increases the runtime from ~1 minute to 2.5 minutes, which shouldn't be a problem.

The second commit fixes it.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

concept ACK, will test locally later today.

TIL DMP_ENABLE_CLANG_TIDY is a cmake option. Does that work in bitcoin core as well?

TIL DMP_ENABLE_CLANG_TIDY is a cmake option.

To be pedantic, the variable name is MP_ENABLE_CLANG_TIDY, and -D is a CMake option to set a variable.

ACK a9499fad755f01e7ceab0954045142cae4b6f9da

Tested on macos by updating bitcoin core subtree to this commit. Ran unit, functional tests and clang tidy. Played with multiprocess binaries, all good. 👍

Code review ACK a9499fad755f01e7ceab0954045142cae4b6f9da. Nice change and coverage improvment

TIL DMP_ENABLE_CLANG_TIDY is a cmake option. Does that work in bitcoin core as well?

I think specifying it with bitcoin core will only enable clang-tidy for libmultiprocess code, but you might be able to get similar behavior for bitcoin core by setting -DCMAKE_CXX_CLANG_TIDY=clang-tidy directly. Downside of using these options is they can noticeably slow down the build though.