Matches the default TEST_RUNNER_TIMEOUT_FACTOR on Bitcoin Core CI.
Should prevent false positives like #256 (comment)
That test relies on a timeout:
0disconnected_log_check.enter_context(node.assert_debug_log(expected_msgs=["IPC server: socket disconnected", "canceled while executing"], timeout=2))
Matches the default TEST_RUNNER_TIMEOUT_FACTOR on Bitcoin Core CI.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | ryanofsky |
If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
I suggest running this PR a few times, optionally after #256 is merged, to see if the timeout is long enough.
Error: Process completed with exit code 143.
https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=263
Resource exhaustion?
Code review ACK 09f10e5a59845e2285f47f12134e78eabc8bd6c6. Obviously good to match bitcoin core timeouts when running bitcoin core tests.
Tests exiting with SIGTERM (https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=263) obviously is concerning, but I don’t think there is a way they could be caused by this change, unless I am missing something. So I think I will merge this to unblock other PRs.
Tests exiting with SIGTERM (https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=263) obviously is concerning, but I don’t think there is a way they could be caused by this change
It turns out this PR reliably causes SIGTERM/143 exit code errors. More cases are:
https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864283?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529932 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529938 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044896?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044932?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257102?pr=249 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257218?pr=249 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23588317635/job/68686883462 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23588317635/job/68686883494
I was thinking these errors might be caused by this tests now waiting longer after this PR for “canceled while executing” log messages, and some other bug like #249 prevents the log messages from showing up, so the job is eventually killed by sigterm.
By the CI runs above show the SIGTERMS happening pretty consistently after the “Run IPC functional tests” step runs for around 2 minutes, after it is running around 40 jobs in parallel, so the resource exhaustion theory makes some more sense now and maybe decreasing the test_runner --jobs 40 argument could fix this. I’m still not sure what would actually be sending the sigterm signals in this case though.