ci: set LC_ALL in shell scripts #265
pull Sjors wants to merge 1 commits into bitcoin-core:master from Sjors:2026/03/lint changing 3 files +6 −0-
Sjors commented at 3:31 pm on March 26, 2026: memberNeeded to make to make the Bitcoin Core linter happy in the next subtree update in https://github.com/bitcoin/bitcoin/pull/34804.
-
ci: set LC_ALL in shell scripts 05d34cc2ec
-
DrahtBot commented at 3:32 pm on March 26, 2026: none
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK ryanofsky If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
-
fanquake commented at 4:15 pm on March 26, 2026: memberThis is probably fine, but also the wrong fix. The linter shouldn’t be linting a subtree (and should be updated to not do so).
-
Sjors commented at 5:25 pm on March 26, 2026: memberHappy to keep this, opened https://github.com/bitcoin/bitcoin/issues/34928 to discuss the Bitcoin Core side.
-
ryanofsky commented at 9:33 am on March 27, 2026: collaborator
Code review ACK 05d34cc2ec3cca2173c249641c51fc1b074f9ab1. Seems good for these scripts to be locale-independent.
I noticed other scripts are using
export LC_ALL=C.UTF-8instead ofexport LC_ALL=Cbut I’m assuming the difference is probably not important. -
ryanofsky merged this on Mar 27, 2026
-
ryanofsky closed this on Mar 27, 2026
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-29 21:30 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-29 21:30 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me