Needed to make to make the Bitcoin Core linter happy in the next subtree update in https://github.com/bitcoin/bitcoin/pull/34804.
ci: set LC_ALL in shell scripts #265
pull Sjors wants to merge 1 commits into bitcoin-core:master from Sjors:2026/03/lint changing 3 files +6 −0-
Sjors commented at 3:31 PM on March 26, 2026: member
-
ci: set LC_ALL in shell scripts 05d34cc2ec
-
DrahtBot commented at 3:32 PM on March 26, 2026: none
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK ryanofsky If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
fanquake commented at 4:15 PM on March 26, 2026: member
This is probably fine, but also the wrong fix. The linter shouldn't be linting a subtree (and should be updated to not do so).
-
Sjors commented at 5:25 PM on March 26, 2026: member
Happy to keep this, opened https://github.com/bitcoin/bitcoin/issues/34928 to discuss the Bitcoin Core side.
-
ryanofsky commented at 9:33 AM on March 27, 2026: collaborator
Code review ACK 05d34cc2ec3cca2173c249641c51fc1b074f9ab1. Seems good for these scripts to be locale-independent.
I noticed other scripts are using
export LC_ALL=C.UTF-8instead ofexport LC_ALL=Cbut I'm assuming the difference is probably not important. - ryanofsky merged this on Mar 27, 2026
- ryanofsky closed this on Mar 27, 2026
