ci: set LC_ALL in shell scripts #265

pull Sjors wants to merge 1 commits into bitcoin-core:master from Sjors:2026/03/lint changing 3 files +6 −0

Sjors commented at 3:31 PM on March 26, 2026: member

Needed to make to make the Bitcoin Core linter happy in the next subtree update in https://github.com/bitcoin/bitcoin/pull/34804.
ci: set LC_ALL in shell scripts 05d34cc2ec
DrahtBot commented at 3:32 PM on March 26, 2026: none



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK ryanofsky

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
fanquake commented at 4:15 PM on March 26, 2026: member

This is probably fine, but also the wrong fix. The linter shouldn't be linting a subtree (and should be updated to not do so).
Sjors commented at 5:25 PM on March 26, 2026: member

Happy to keep this, opened https://github.com/bitcoin/bitcoin/issues/34928 to discuss the Bitcoin Core side.
ryanofsky commented at 9:33 AM on March 27, 2026: collaborator

Code review ACK 05d34cc2ec3cca2173c249641c51fc1b074f9ab1. Seems good for these scripts to be locale-independent.

I noticed other scripts are using export LC_ALL=C.UTF-8 instead of export LC_ALL=C but I'm assuming the difference is probably not important.
ryanofsky merged this on Mar 27, 2026
ryanofsky closed this on Mar 27, 2026
ryanofsky referenced this in commit db2dc76ee3 on Mar 27, 2026
ryanofsky referenced this in commit 2478a15ef9 on Mar 30, 2026
fanquake referenced this in commit b0f68f0a3a on Mar 30, 2026
fanquake referenced this in commit 7375940eb2 on Apr 1, 2026
Sjors referenced this in commit 65abfa3c1a on Apr 15, 2026
morozow referenced this in commit 08e84496a9 on May 8, 2026
Sjors referenced this in commit 0dd3f5c989 on May 12, 2026

Type	Reviewers
ACK	ryanofsky

Contributors

ci: set LC_ALL in shell scripts #265

Reviews