Limit LogEscape string size #3

pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/logsize changing 1 files +6 −0

ryanofsky commented at 6:24 PM on July 15, 2019: collaborator

Try to avoid massive debug log file sizes, and travis MemoryError in https://github.com/bitcoin/bitcoin/pull/10102, https://travis-ci.org/bitcoin/bitcoin/jobs/558040257:

TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_framework.py", line 193, in main
    self.run_test()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/feature_block.py", line 1222, in run_test
    self.send_blocks(blocks, True, timeout=1500)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/feature_block.py", line 1373, in send_blocks
    self.nodes[0].p2p.send_blocks_and_test(blocks, self.nodes[0], success=success, reject_reason=reject_reason, force_send=force_send, timeout=timeout, expect_disconnect=reconnect)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/mininode.py", line 553, in send_blocks_and_test
    assert node.getbestblockhash() != blocks[-1].hash
  File "/usr/lib/python3.6/contextlib.py", line 88, in __exit__
    next(self.gen)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_node.py", line 318, in assert_debug_log
    log = dl.read()
  File "/usr/lib/python3.6/codecs.py", line 321, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
MemoryError

Limit LogEscape string size

Try to avoid massive debug log file sizes, and travis MemoryError in
https://github.com/bitcoin/bitcoin/pull/10102:

TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_framework.py", line 193, in main
    self.run_test()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/feature_block.py", line 1222, in run_test
    self.send_blocks(blocks, True, timeout=1500)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/feature_block.py", line 1373, in send_blocks
    self.nodes[0].p2p.send_blocks_and_test(blocks, self.nodes[0], success=success, reject_reason=reject_reason, force_send=force_send, timeout=timeout, expect_disconnect=reconnect)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/mininode.py", line 553, in send_blocks_and_test
    assert node.getbestblockhash() != blocks[-1].hash
  File "/usr/lib/python3.6/contextlib.py", line 88, in __exit__
    next(self.gen)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/test/functional/test_framework/test_node.py", line 318, in assert_debug_log
    log = dl.read()
  File "/usr/lib/python3.6/codecs.py", line 321, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
MemoryError

724d2f7fe3

ryanofsky merged this on Jul 15, 2019
ryanofsky closed this on Jul 15, 2019
ryanofsky referenced this in commit 45785e7f19 on Jul 15, 2019
bitcoin-core locked this on Jun 25, 2025

Contributors

ryanofsky

Linked (view graph)

#115 MSAN Error during connection shutdown #162 macos "Broken pipe" exceptions during tests #176 IPC segfault with 32345 + 29409 + custom client #219 SIGABRT in ~ProxyClientBase with #29409 and rust client #259 bug: `EventLoop::post()` deadlocks when posted function throws