Fix empty exception values from bad ThrowFn declaration #33

pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/except changing 4 files +11 −1

ryanofsky commented at 10:06 PM on March 22, 2020: collaborator

Also extend libmultiprocess unit test with coverage for this case.

Bad non-const ThrowFn declaration was causing ReadDestEmplace to try read exception values after throwing them instead of before (in update_fn(construct()) expression when construct() callback throws).

This was causing bitcoin functional tests to fail because JSONRPCError exceptions caught were just null UniValue objects instead of objects with code and message fields set.

Fix empty exception values from bad ThrowFn declaration

Also extend libmultiprocess unit test with coverage for this case.

Bad non-const ThrowFn declaration was causing ReadDestEmplace to try read
exception values after throwing them instead of before (in
update_fn(construct()) expression when construct() callback throws).

This was causing bitcoin functional tests to fail because JSONRPCError
exceptions caught were just null UniValue objects instead of objects with code
and message fields set.

c3efcae099

ryanofsky merged this on Mar 22, 2020
ryanofsky closed this on Mar 22, 2020
bitcoin-core locked this on Jun 25, 2025

Contributors

ryanofsky

Linked (view graph)

#115 MSAN Error during connection shutdown #219 SIGABRT in ~ProxyClientBase with #29409 and rust client