Disable GCC suggest-override warnings for proxy clients #40

pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/overwarn changing 1 files +7 −0

ryanofsky commented at 6:32 PM on December 8, 2020: collaborator

Proxy client methods are usually virtual, but in some use cases (testing, layering) they don't have to have to be and there is no reason to make generated client code try to detect or specify this. Disable the warning instead.

Warnings look like https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

./ipc/capnp/init.capnp.proxy.h:62:25: error: ‘virtual mp::FunctionTraits<std::unique_ptr<interfaces::Echo> (interfaces::Init::* const)()>::Result mp::ProxyClient<ipc::capnp::messages::Init>::makeEcho()’ can be marked override [-Werror=suggest-override]
   62 |     typename M1::Result makeEcho();
      |                         ^~~~~~~~
cc1plus: some warnings being treated as errors

Disable GCC suggest-override warnings for proxy clients

Proxy client methods are usually virtual, but in some use cases (testing,
layering) they don't have to have to be and there is no reason to make
generated client code try to detect or specify this. Disable the warning
instead.

Warnings look like https://cirrus-ci.com/task/6000489311502336?command=ci#L4294

./ipc/capnp/init.capnp.proxy.h:62:25: error: ‘virtual mp::FunctionTraits<std::unique_ptr<interfaces::Echo> (interfaces::Init::* const)()>::Result mp::ProxyClient<ipc::capnp::messages::Init>::makeEcho()’ can be marked override [-Werror=suggest-override]
   62 |     typename M1::Result makeEcho();
      |                         ^~~~~~~~
cc1plus: some warnings being treated as errors

05f9817c36

ryanofsky merged this on Dec 8, 2020
ryanofsky closed this on Dec 8, 2020
ryanofsky referenced this in commit 4c3cac5440 on Dec 8, 2020
ryanofsky referenced this in commit af5bc75feb on Dec 11, 2020
ryanofsky referenced this in commit b15c4f8bdc on Dec 11, 2020
ryanofsky referenced this in commit dbe1df98fc on Dec 18, 2020
ryanofsky referenced this in commit 8877892266 on Dec 18, 2020
ryanofsky referenced this in commit 29e574aed8 on Jan 28, 2021
ryanofsky referenced this in commit c4ee00e947 on Jan 28, 2021
ryanofsky referenced this in commit 97232e7c62 on Mar 4, 2021
ryanofsky referenced this in commit b1cacee1b4 on Mar 4, 2021
ryanofsky referenced this in commit 1ecf3dcc52 on Mar 4, 2021
ryanofsky referenced this in commit 35cfc59500 on Mar 17, 2021
ryanofsky referenced this in commit 7e43e7a556 on Mar 17, 2021
ryanofsky referenced this in commit 1930323ae9 on Mar 17, 2021
ryanofsky referenced this in commit 4cb21574b8 on Mar 30, 2021
ryanofsky referenced this in commit 85f47de8f0 on Mar 30, 2021
ariard referenced this in commit 14ec1dec98 on Apr 6, 2021
ryanofsky referenced this in commit f1f62325ec on Apr 23, 2021
ryanofsky referenced this in commit 5d62d7f6cd on Apr 23, 2021
ryanofsky referenced this in commit 921e23e8d1 on Dec 22, 2021
bitcoin-core locked this on Jun 25, 2025

Contributors

ryanofsky

Linked (view graph)

#115 MSAN Error during connection shutdown #219 SIGABRT in ~ProxyClientBase with #29409 and rust client