Comments and LogEscape #45

pull jamesob wants to merge 4 commits into bitcoin-core:master from jamesob:jamesob-2021-03-misc changing 3 files +20 −7

jamesob commented at 4:49 PM on March 15, 2021: contributor

Just a few little changes made while reviewing. Feel free to discard or change any of the documentation edits.
README: add kj explainer b6e060af7b
doc: fix various typos 6e36f0f53c
doc: add note on vats 89ababdd3c
util: fix LogEscape bug 22afe27d1e
jamesob requested review from ryanofsky on Mar 15, 2021

in src/mp/util.cpp:84 in 22afe27d1e

  80 | @@ -81,7 +81,7 @@ std::string LogEscape(const kj::StringTree& string)
  81 |      string.visit([&](const kj::ArrayPtr<const char>& piece) {
  82 |          if (result.size() > MAX_SIZE) return;
  83 |          for (char c : piece) {
  84 | -            if ('c' == '\\') {

ryanofsky commented at 5:32 PM on March 15, 2021:

🤦

jamesob commented at 5:41 PM on March 15, 2021:

Surprised there isn't a compiler warning for these kinds of things.

in include/mp/proxy-io.h:347 in 89ababdd3c outdated

 342 | +//! "Vat" is Cap'n Proto nomenclature for a host of various objects that facilitates
 343 | +//! bidirectional communication with other vats; it is often but not always 1-1 with
 344 | +//! processes. Cap'n Proto doesn't reference clients or servers per se; instead everything
 345 | +//! is just a vat.
 346 | +//!
 347 | +//! See also: https://github.com/capnproto/capnproto/blob/9021f0c722b36cb11e3690b0860939255ebad39c/c%2B%2B/src/capnp/rpc.capnp#L42-L56

ryanofsky commented at 5:35 PM on March 15, 2021:

Further back, it's from E https://en.wikipedia.org/wiki/E_(programming_language)#Computational_model

ryanofsky merged this on Mar 15, 2021
ryanofsky closed this on Mar 15, 2021
ryanofsky commented at 6:41 PM on March 15, 2021: collaborator

Thank you!
bitcoin-core locked this on Jun 25, 2025

Contributors

jamesob

ryanofsky

Linked (view graph)

#115 MSAN Error during connection shutdown