Fix clang compiler warnings #62

pull ryanofsky wants to merge 3 commits into bitcoin-core:master from ryanofsky:pr/cwarn changing 2 files +4 −4

ryanofsky commented at 2:14 AM on December 22, 2021: collaborator

Avoid and suppress various warnings reported in https://github.com/chaincodelabs/libmultiprocess/issues/61

Disable clang suggest-override warnings for proxy clients

Warnings look like "warning: 'initError' overrides a member function but
is not marked 'override' [-Wsuggest-override]"

Warnings were originally reported by Sjors Provoost <sjors@sprovoost.nl>
and are tracked in
https://github.com/chaincodelabs/libmultiprocess/issues/61

The same warnings were previously disabled for GCC in
05f9817c369a5b74a9a802b0af063c103560a1cc
https://github.com/chaincodelabs/libmultiprocess/pull/40 and that change
is extended here to apply to clang. The methods triggering the warnings
are not virtual in all cases and should not have the override keyword.

921e23e8d1

Avoid delete-non-abstract-non-virtual-dtor warnings

Warnings look like "warning: destructor called on non-final
'mp::ProxyClient<ipc::capnp::messages::ActorCallback>' that has virtual
functions but non-virtual destructor
[-Wdelete-non-abstract-non-virtual-dtor]"

Warnings were originally reported by Sjors Provoost <sjors@sprovoost.nl>
and are tracked in
https://github.com/chaincodelabs/libmultiprocess/issues/61

Avoid these by adding final keywords to generated class declarations

5738b8ae09

Avoid delete-non-abstract-non-virtual-dtor warnings for mp::ProxyCallbackImpl

Warnings look like "warning: destructor called on non-final
'mp::ProxyCallbackImpl<void>' that has virtual functions but non-virtual
destructor [-Wdelete-non-abstract-non-virtual-dtor]"

Avoid these by adding final keyword to class declaration

1b638d67de

ryanofsky merged this on Dec 22, 2021
ryanofsky closed this on Dec 22, 2021
bitcoin-core locked this on Jun 25, 2025

Contributors

ryanofsky