Fix CMake minimum required version #69

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:220826-minver changing 1 files +1 −1

hebasto commented at 10:38 PM on August 26, 2022: member

The "C++17" value of the CXX_STANDARD target property, which was introduced in chaincodelabs/libmultiprocess#25, is available in CMake 3.8 and newer.

Tested with old CMake versions available here.

Fix CMake minimum required version

The "C++17" value of the `CXX_STANDARD` target property, which was
introduced in chaincodelabs/libmultiprocess#25, is available in
CMake 3.8 and newer.

6902bfd40e

in CMakeLists.txt:5 in 6902bfd40e
```
   1 | @@ -2,7 +2,7 @@
   2 |  # Distributed under the MIT software license, see the accompanying
   3 |  # file COPYING or http://www.opensource.org/licenses/mit-license.php.
   4 |  
   5 | -cmake_minimum_required(VERSION 3.0)
   6 | +cmake_minimum_required(VERSION 3.8)
```
hebasto commented at 10:57 PM on August 26, 2022:

Considering https://repology.org/project/cmake/versions, maybe 3.10 is also justified?

ryanofsky commented at 5:54 PM on August 29, 2022:

Considering https://repology.org/project/cmake/versions, maybe 3.10 is also justified?

I'm not actually sure what specifically here requires 3.10, but would welcome any followup PR that changes the minimum version or adds a comment explaining the current minimum.

hebasto commented at 8:18 AM on August 30, 2022:

I'm not actually sure what specifically here requires 3.10

Nothing requires 3.10. Just thinking about availability of CMake 3.8 and 3.9 on real systems.
ryanofsky approved
ryanofsky commented at 5:55 PM on August 29, 2022: collaborator

Code review ACK 6902bfd40e33a0007f75bce8af0fc0b10a147e86. Thanks for the PR!
ryanofsky merged this on Aug 29, 2022
ryanofsky closed this on Aug 29, 2022
hebasto deleted the branch on Aug 29, 2022
bitcoin-core locked this on Jun 25, 2025

Contributors

hebasto

ryanofsky