It doesn't look robust to use different C++ standards for configuration and building.
This PR, for example, will apply the -std=gnu++17 compiler option for all checks during configuration when building with GCC.
Use defined `CXX_STANDARD` for environment introspection #71
pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:220831-standard changing 3 files +6 −18-
hebasto commented at 12:09 PM on August 31, 2022: member
-
Use defined `CXX_STANDARD` for environment introspection 2eff5da83c
- ryanofsky approved
-
ryanofsky commented at 6:54 PM on August 31, 2022: collaborator
Code review ACK 2eff5da83c5dfcb13d28df7c2c108178bbcba956. The original reason this was implemented this way was that some versions of capnproto required c++14 while bitcoin was still using c++11, so there really was a mix of versions being used together. But it is simpler to set a default version now, and good to use the same version for checks.
- ryanofsky merged this on Aug 31, 2022
- ryanofsky closed this on Aug 31, 2022
- hebasto deleted the branch on Aug 31, 2022
- bitcoin-core locked this on Jun 25, 2025
