Warnings (soon-to-be) emitted in the Core multiprocess build #77

issue fanquake opened this issue on September 14, 2022
  1. fanquake commented at 2:02 PM on September 14, 2022: member

    We are looking at re-enabling a more comprehensive set of warnings (by default) for depends builds, and currently the multiprocess CI job is emitting a few:

    In file included from ipc/capnp/protocol.cpp:14:
    /tmp/cirrus-ci-build/depends/i686-pc-linux-gnu/include/mp/proxy-io.h:33:37: error: parameter 'connection' shadows member inherited from type 'InvokeContext' [-Werror,-Wshadow-field]
        ClientInvokeContext(Connection& connection, ThreadContext& thread_context)
                                        ^
    /tmp/cirrus-ci-build/depends/i686-pc-linux-gnu/include/mp/proxy-io.h:27:17: note: declared here
        Connection& connection;
                    ^
    /tmp/cirrus-ci-build/depends/i686-pc-linux-gnu/include/mp/proxy-io.h:160:16: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
            return std::move(logger);
                   ^
    /tmp/cirrus-ci-build/depends/i686-pc-linux-gnu/include/mp/proxy-io.h:160:16: note: remove std::move call here
            return std::move(logger);
                   ^~~~~~~~~~      ~
    2 errors generated.
    
  2. ryanofsky commented at 6:22 PM on September 14, 2022: collaborator

    Thanks, these should be pretty easy to fix. Will try to do it soon or can merge a PR.

  3. hebasto commented at 9:20 AM on September 16, 2022: member

    -Wpessimizing-move warnings have been already fixed in #58.

  4. ryanofsky closed this on Sep 19, 2022

  5. bitcoin-core locked this on Jun 25, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 19:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me