Avoid passing some function arguments by value #84

pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/tidyv changing 4 files +7 −7
  1. ryanofsky commented at 9:23 PM on February 14, 2023: collaborator

    Preemptively avoid clang-tidy errors before clang-tidy is introduced in https://github.com/chaincodelabs/libmultiprocess/pull/83. Other clang errors are already fixed in that PR, but these aren't maybe due to running different clang-tidy versions. The errors look like:

    include/mp/proxy-types.h:162:85: warning: the parameter 'perhaps' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
                                .then([&server, invoke, req](kj::Maybe<Thread::Server&> perhaps) {
                                                                                        ^
                                                             const                     &
    example/printer.cpp:27:39: warning: the parameter 'message' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
    void LogPrint(bool raise, std::string message)
                                          ^
    example/printer.cpp:29:41: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
        if (raise) throw std::runtime_error(std::move(message));
                                            ^~~~~~~~~~       ~
    
  2. Avoid passing some function arguments by value
    Preemptively avoid clang-tidy errors before clang-tidy is introduced in
    https://github.com/chaincodelabs/libmultiprocess/pull/83. Other clang errors
    are already fixed in that PR, these aren't (maybe due to running different
    clang-tidy versions). The errors look like:
    
    include/mp/proxy-types.h:162:85: warning: the parameter 'perhaps' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
                                .then([&server, invoke, req](kj::Maybe<Thread::Server&> perhaps) {
                                                                                        ^
                                                             const                     &
    example/printer.cpp:27:39: warning: the parameter 'message' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
    void LogPrint(bool raise, std::string message)
                                          ^
    example/printer.cpp:29:41: warning: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg]
        if (raise) throw std::runtime_error(std::move(message));
                                            ^~~~~~~~~~       ~
    8ef94d2e86
  3. ryanofsky merged this on Feb 14, 2023
  4. ryanofsky closed this on Feb 14, 2023

  5. bitcoin-core locked this on Jun 25, 2025
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 18:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me