Invoke capnp compile from mpgen #9

pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/2gen changing 3 files +105 −48

ryanofsky commented at 5:57 PM on August 6, 2019: collaborator

This simplifies multiprocess build code somewhat (https://github.com/bitcoin/bitcoin/pull/16367) so it only has to invoke one code generator instead of two, and is probably a little more future proof in that is should make it possible to change capnp options without any requiring changes outside libmultiprocess.
ryanofsky merged this on Aug 6, 2019
ryanofsky closed this on Aug 6, 2019
ryanofsky referenced this in commit 9cd1a5a9c1 on Aug 6, 2019
hebasto commented at 3:28 PM on May 1, 2022: member

A commit from the future:

:smiley:
ryanofsky commented at 2:30 PM on May 13, 2022: collaborator

:smiley:

Yeah, I messed this up, and there isn't a good way to fix it without rewriting all the hashes in commit history. Could do if I find a convenient tool that does this.

in src/mp/gen.cpp:527 in f89e4b32dc

 523 | @@ -475,13 +524,13 @@ void Generate(kj::StringPtr output_stem, kj::StringPtr input_schema, kj::ArrayPt
 524 |  int main(int argc, char** argv)
 525 |  {
 526 |      if (argc < 3) {
 527 | -        fprintf(stderr, "Usage: " PROXY_BIN " OUTPUT_STEM INPUT_SCHEMA [IMPORT_PATH...]\n");
 528 | +        fprintf(stderr, "Usage: " PROXY_BIN " SRC_PREFIX SRC_FILE [IMPORT_PATH...]\n");

hebasto commented at 3:26 PM on September 16, 2022:

Should it be

-        fprintf(stderr, "Usage: " PROXY_BIN " SRC_PREFIX SRC_FILE [IMPORT_PATH...]\n");
+        fprintf(stderr, "Usage: " PROXY_BIN " SRC_PREFIX INCLUDE_PREFIX SRC_FILE [IMPORT_PATH...]\n");

ryanofsky commented at 6:47 PM on September 19, 2022:

Should it be

Good catch. Should be fixed in #80

ryanofsky referenced this in commit fcad5fbe53 on Sep 19, 2022
ryanofsky referenced this in commit 7441069261 on Sep 19, 2022
bitcoin-core locked this on Jun 25, 2025

Invoke capnp compile from mpgen

This simplifies multiprocess build code somewhat
(https://github.com/bitcoin/bitcoin/pull/16367) so it only has to invoke one
code generator instead of two, and is probably a little more future proof in
that is should make it possible to change capnp options without any requiring
changes outside libmultiprocess.

f89e4b32dc

Contributors

ryanofsky

hebasto

Linked (view graph)

#115 MSAN Error during connection shutdown #162 macos "Broken pipe" exceptions during tests #219 SIGABRT in ~ProxyClientBase with #29409 and rust client #259 bug: `EventLoop::post()` deadlocks when posted function throws