Fix support for vector<bool> serialization with libc++ #93

pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/fbool changing 1 files +1 −1
  1. ryanofsky commented at 4:32 PM on January 22, 2024: collaborator

    The vector<bool> serialization support added in https://github.com/chaincodelabs/libmultiprocess/pull/86 commit 1c6fb04dddfc0de35eb5952649fda83a030ff288 was only tested with libstdc++ not libc++ and caused a test compilation failure when compiling on macos, reported by edilmedeiros in https://github.com/chaincodelabs/libmultiprocess/issues/92

    Fix the issue that was causing the build to fail: trying to use using vector's reference type instead of const_reference type when serializing the vector.

    Fixes #92

  2. Fix support for vector<bool> serialization with libc++
    The vector<bool> serialization supported added in
    https://github.com/chaincodelabs/libmultiprocess/pull/86 commit
    1c6fb04dddfc0de35eb5952649fda83a030ff288 was only tested with libstdc++ not
    libc++ and caused a test compilation failure when compiling on macos, reported
    by edilmedeiros in https://github.com/chaincodelabs/libmultiprocess/issues/92
    
    Fix the issue that was causing the build to fail: trying to use using vector's
    reference type instead of const_reference type when serializing the vector.
    
    Fixes #92
    10fc3eda9c
  3. ryanofsky merged this on Jan 22, 2024
  4. ryanofsky closed this on Jan 22, 2024

  5. ryanofsky referenced this in commit b8105b3ed7 on Jan 22, 2024
  6. edilmedeiros commented at 12:22 AM on January 23, 2024: none

    I confirm that the changes in 8da797c now make the tests compile and pass in my box. I compiled and checked them by getting dependencies from both Brew and Macports.

  7. fanquake referenced this in commit f1ab078ed7 on Jan 23, 2024
  8. 0xB10C referenced this in commit d9baf06506 on Jan 24, 2024
  9. janus referenced this in commit 86470d732b on Apr 6, 2024
  10. PastaPastaPasta referenced this in commit fcb0d3ccf4 on Sep 27, 2024
  11. PastaPastaPasta referenced this in commit c7e42416ff on Sep 27, 2024
  12. PastaPastaPasta referenced this in commit 2758ba8cd9 on Sep 27, 2024
  13. PastaPastaPasta referenced this in commit 914582ecbd on Sep 28, 2024
  14. PastaPastaPasta referenced this in commit 7a63c20c47 on Oct 1, 2024
  15. bitcoin-core locked this on Jun 25, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 18:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me