Use compute credits for valgrind job #114

pull dergoegge wants to merge 1 commits into bitcoin-core:main from dergoegge:2023-04-cirrus-credits changing 1 files +12 −3
  1. dergoegge commented at 2:45 pm on April 12, 2023: member
  2. dergoegge commented at 4:57 pm on April 12, 2023: member
    Timed out at 2 hours, probably needs some kind of permission to use the credits?
  3. in .cirrus.yml:14 in e329524a65 outdated
    10 task:
    11   name: "[system libs, no depends, fuzz, valgrind]  [jammy]"
    12   container:
    13     image: ubuntu:22.04
    14-    cpu: 4
    15+    cpu: 8
    


    maflcko commented at 5:22 pm on April 12, 2023:

    Funnily, increasing the cpu doesn’t do much, because with greedy: true you practically already get 16-20 cpus. It could make more sense to keep the cpu the same and only increase the time.

    The most CPU is consumed by one or two tasks that run for the longest time. So to be more cost-efficient, decreasing the cpu would be better. But here it is not possible, because of the memory requirements: each 4 GB of memory requires at least 1 CPU.


    dergoegge commented at 6:02 pm on April 12, 2023:
    I see, thanks! Will update tomorrow.
  4. dergoegge force-pushed on Apr 13, 2023
  5. in .cirrus.yml:15 in 86dcb7b24a outdated
    10 task:
    11   name: "[system libs, no depends, fuzz, valgrind]  [bookworm]"
    12   container:
    13     image: debian:bookworm
    14     cpu: 4
    15     memory: 16G
    


    maflcko commented at 4:38 pm on April 13, 2023:
    0    cpu: 3
    1    memory: 12G
    

    looking at the chart, this may even be reduced, but i am not sure if 3 is an acceptable number

  6. in .cirrus.yml:17 in 86dcb7b24a outdated
    13     image: debian:bookworm
    14     cpu: 4
    15     memory: 16G
    16     greedy: true
    17-  timeout_in: 120m
    18+  timeout_in: 240m
    


    maflcko commented at 4:39 pm on April 13, 2023:
    I’d be surprised if this was enough
  7. Use compute credits for valgrind job 8db2931e93
  8. dergoegge force-pushed on Apr 19, 2023
  9. dergoegge commented at 9:55 am on April 19, 2023: member
    Updated config: 3 cores, 12GB, 480m
  10. maflcko commented at 12:12 pm on April 19, 2023: contributor

    lgtm. Maybe just merge to see if it will use credits then?

    Max cost should be 3*0.48*5$=7.2$ ?

  11. fanquake commented at 12:44 pm on April 19, 2023: member

    lgtm. Maybe just merge to see if it will use credits then?

    Ok. We’ll merge this now, and see what happens in the CI run.

  12. fanquake merged this on Apr 19, 2023
  13. fanquake closed this on Apr 19, 2023


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/qa-assets. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-07 00:25 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me