Add fuzz seeds from 25rc1 #124

1. 
   murchandamus commented at 9:28 pm on May 8, 2023: contributor

   Draft: Testing whether I’m doing this right so far, before I throw more compute at fuzzing.
2. 
   maflcko commented at 9:05 am on May 9, 2023: contributor

   Usually I use current running master. I don’t think there was ever an instance where an input on a release branch triggered a bug that wouldn’t trigger on master as well, and vice-versa. Though, if there are meaningful backports to a release branch, this could change.

   So Concept ACK. I presume you merged this with 25rc1 compiled and not master?

3. 
   murchandamus commented at 9:48 pm on May 12, 2023: contributor

   Yes, exactly, I was fuzzing with 25rc1. I’ve been fuzzing more while I was traveling, only to learn that libfuzzer appears to take the first of either -runs or -max_total_time and you can’t combine the two to make it stop whenever you hit one of the two limits. So… was fuzzing one thing for 35h, instead of everything for up to 20 minutes. Will merge my results on Monday and update this PR then.
4. murchandamus force-pushed on May 16, 2023
5. 
   murchandamus commented at 2:33 pm on May 16, 2023: contributor

   Fuzzed every target for another 20 minutes.
6. 
   maflcko commented at 3:16 pm on May 16, 2023: contributor

   about wallet_notifications: #121 (comment)
7. 
   murchandamus commented at 1:01 pm on May 22, 2023: contributor

   @MarcoFalke: Damn, that was one of the things that were really slow to fuzz. ;) So, do I understand you right that you are asking that I delete the content of the wallet_notifications target?
8. 
   maflcko commented at 1:07 pm on May 22, 2023: contributor

   Yeah, for now. Longer term it might be good to rework the fuzz target or come up with a different solution.
9. Add fuzz seeds from 25rc1 f724b921fc
10. murchandamus force-pushed on May 22, 2023
11. 
    murchandamus commented at 2:51 pm on May 22, 2023: contributor

    Updated to remove wallet_notifications fuzz seeds
12. 
    maflcko commented at 2:54 pm on May 24, 2023: contributor

    this: https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/monotree/fa95970671c2dc22/f724b921fcddfaac/fuzz.coverage/index.html

    nightly: https://marcofalke.github.io/b-c-cov/fuzz.coverage/index.html

13. 
    maflcko commented at 2:54 pm on May 24, 2023: contributor

    Can’t really find new coverage, but I guess it doesn’t hurt too much either?

    lgtm

14. 
    fanquake commented at 3:04 pm on May 24, 2023: member

    @dergoegge
15. dergoegge approved
16. 
    dergoegge commented at 3:20 pm on May 24, 2023: member

    lgtm
17. fanquake merged this on May 24, 2023
18. fanquake closed this on May 24, 2023

    ---

19. 
    murchandamus commented at 3:43 pm on June 13, 2023: contributor

    Can’t really find new coverage, but I guess it doesn’t hurt too much either?

    lgtm

    I’m confused. If these new files didn’t increase the coverage, why did the merge not remove them? Did I do it wrong? :-/

20. 
    maflcko commented at 3:57 pm on June 13, 2023: contributor

    The merge uses -use_value_profile=1, IIRC, and the fuzz engine may use some other stuff internally, which triggers on more than just Function/Line/Branch coverage and may include fuzz inputs that appear otherwise “redundant”.

Contributors
murchandamus maflcko fanquake dergoegge