Collect process_message_* inputs into one folder #138

pull maflcko wants to merge 1 commits into bitcoin-core:main from maflcko:main changing 0 files +0 −0
  1. maflcko commented at 12:48 pm on July 13, 2023: contributor

    This is a follow-up to #131 (comment)

    It should have moved the inputs in the first place to avoid duplicating them. There is no value in duplicating them. While .git can de-duplicate the files internally, it still hurts storage when the files are checked out. Also it hurts CPU when the fuzz runner is running the same input twice.

  2. Collect process_message_* inputs into one folder ca4413bd7f
  3. maflcko commented at 12:50 pm on July 13, 2023: contributor

    Done with:

    0cd ./fuzz_seed_corpus/
    1for p in ./process_message_* ; do git mv --force ./$p/* ./process_message/ ; done
    
  4. fanquake commented at 9:38 am on July 14, 2023: member
  5. maflcko commented at 2:33 pm on July 14, 2023: contributor
    (CI can be ignored, obviously)
  6. maflcko commented at 9:10 am on July 28, 2023: contributor
    Should be trivial to reproduce the scripted diff with the bash oneliner above. Also review should be trivial, no?
  7. dergoegge commented at 9:21 am on July 28, 2023: member

    Should be trivial to reproduce the scripted diff with the bash oneliner above. Also review should be trivial, no?

    Sorry dropped of my radar.

    Can’t we just delete the individual folders, since we merged the inputs in #131?

  8. maflcko commented at 9:29 am on July 28, 2023: contributor

    Can’t we just delete the individual folders, since we merged the inputs in #131?

    Yes, happy to do that. There might be a small benefit in keeping all inputs for now, so that the targets from transform_process_message_target have access to all the same fuzz inputs that were there previously before moving everything into one folder.

    But it shouldn’t matter, because the next https://github.com/bitcoin-core/qa-assets#pruning-inputs run will delete them anyway. So happy to do either.

  9. dergoegge commented at 9:33 am on July 28, 2023: member
    ACK ca4413bd7f86a63f249fd5fb2f6f2c4875159f3e
  10. fanquake merged this on Jul 28, 2023
  11. fanquake closed this on Jul 28, 2023


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/qa-assets. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 00:25 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me