Delete nonreduced inputs #157

1. 
   maflcko commented at 2:41 pm on October 23, 2023: contributor

   As per the usual process to avoid wasted CI resources and timeouts when it runs on large and presumed irrelevant inputs.

   Previous: #119

   To “reproduce”

   Install a fresh VM, as explained in the bash script’s doc, and run it:

   0apt update && apt install curl -y
   1curl -L -O https://raw.githubusercontent.com/bitcoin-core/bitcoin-maintainer-tools/main/delete_nonreduced_fuzz_inputs.sh
   2bash delete_nonreduced_fuzz_inputs.sh
   

   To “test”

   • Keep an eye on coverage stats, to ensure it doesn’t drop
   • Re-run the script, to ensure it is “reproducible” to some extent
   • Anything else you think is important to test or review
2. Delete fuzz inputs 4b8b07da39
3. Reduced inputs for fuzzer a45c724918
4. Reduced inputs for fuzzer,address,undefined,integer 01a9287310
5. 
   maflcko commented at 3:04 pm on October 23, 2023: contributor

   Did a second run. Some stats:

   • 400k deleted files (this pull):

   0# git diff --stat origin/main..01a9287310b6c2e6344e28c4ba655d179142f719 | tail -1
   1 446405 files changed, 5974234 deletions(-)
   

   • Same on the second run:

   0# git diff --stat origin/main..HEAD | tail -1
   1 444894 files changed, 5404772 deletions(-)
   

   • Cross-diff of 24k files:

   0# git diff --stat 01a9287310b6c2e6344e28c4ba655d179142f719..HEAD | tail -1
   1 23461 files changed, 50266 insertions(+), 4085 deletions(-)
   

6. 
   maflcko commented at 3:04 pm on October 23, 2023: contributor

   lint fail is expected (obviously)

   cc @murchandamus @dergoegge

7. Remove large utxo_total_supply fuzz inputs for now 428a2e7b0d
8. 
   maflcko commented at 9:58 am on October 24, 2023: contributor

   Looks like utxo_total_supply is the reason for the 2h timeout. I’ve removed the large fuzz inputs in this folder for now.
9. 
   maflcko commented at 11:19 am on October 24, 2023: contributor

   Looks like the CI passed after 43minutes now: https://cirrus-ci.com/task/4832424811560960?logs=ci#L4022
10. 
    dergoegge commented at 12:03 pm on October 24, 2023: member

    Looks like utxo_total_supply is the reason for the 2h timeout. I’ve removed the large fuzz inputs in this folder for now.

    We could add options for that target either to oss-fuzz or in the target itself (e.g. if (buffer.size() > N) return;) to avoid large inputs in the future.

11. 
    maflcko commented at 12:32 pm on October 24, 2023: contributor

    Let’s create a separate tracking issue for this target?
12. 
    maflcko commented at 5:57 pm on October 24, 2023: contributor

    The coverage report for this commit: https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/monotree/004367dba8a3e852/428a2e7b0def5102/fuzz.coverage/index.html
13. 
    dergoegge commented at 8:11 am on October 25, 2023: member

    ACK 428a2e7b0def51025b425bee15141a232ff7189c

    0root@0e503e9c42d6:/qa-assets# git diff --stat origin/main..HEAD | tail -1
    1 445073 files changed, 5399978 deletions(-)
    

14. fanquake merged this on Oct 25, 2023
15. fanquake closed this on Oct 25, 2023

    ---

Contributors
maflcko dergoegge