script_flags fuzz format change #159

1. 
   maflcko commented at 10:32 am on November 27, 2023: contributor

   Transform the inputs after the format change in https://github.com/bitcoin/bitcoin/commit/fa6b87b9ee661d8ef4ec244d230ebdeb7d1841a0

   Done by nuking the first 4 bytes with something like:

   0for f in ./script_flags/* ; do python -c "fn=\"$f\"; print(fn); open(fn+'.new', 'wb').write(open(fn,'rb').read()[4:]);" ; done
   

2. script_flags fuzz format change 927ed17c17
3. dergoegge approved
4. 
   dergoegge commented at 10:56 am on November 27, 2023: member

   lgtm

   https://github.com/bitcoin/bitcoin/commit/6e9e4e6130797b721c8df1eabaf46ec25ebb6abe also changed the input format fwiw

5. 
   maflcko commented at 11:09 am on November 27, 2023: contributor

   bitcoin/bitcoin@6e9e4e6 also changed the input format fwiw

   Only for src/test/fuzz/rpc.cpp, no?

6. 
   dergoegge commented at 11:14 am on November 27, 2023: member

   I might be wrong but after https://github.com/bitcoin/bitcoin/commit/6e9e4e6130797b721c8df1eabaf46ec25ebb6abe script_flags always deserializes txs with witness, which was decided based on the the stream version before, right?
7. 
   maflcko commented at 11:20 am on November 27, 2023: contributor

   Ah, right. But I guess there is no trivial python one-liner to transform those.
8. 
   dergoegge commented at 11:21 am on November 27, 2023: member

   Ah, right. But I guess there is no trivial python one-liner to transform those.

   Yea I was just making a note of it, not saying you need change anything here.

9. 
   maflcko commented at 1:21 pm on November 27, 2023: contributor

   rfm?
10. fanquake merged this on Nov 27, 2023
11. fanquake closed this on Nov 27, 2023

    ---

Contributors
maflcko dergoegge