Prune inputs #177

1. 
   dergoegge commented at 1:59 pm on March 18, 2024: member

   As per the usual process to avoid wasted CI resources and timeouts when it runs on large and presumed irrelevant inputs.

   Previous: #157

   To “reproduce”

   Install a fresh VM, as explained in the bash script’s doc, and run it:

   0apt update && apt install wget -y
   1wget https://raw.githubusercontent.com/bitcoin-core/bitcoin-maintainer-tools/main/delete_nonreduced_fuzz_inputs.sh
   2bash delete_nonreduced_fuzz_inputs.sh
   

   To “test”

   • Keep an eye on coverage stats, to ensure it doesn’t drop
   • Re-run the script, to ensure it is “reproducible” to some extent
   • Anything else you think is important to test or review
2. Delete fuzz inputs d47b81e470
3. Reduced inputs for fuzzer 723428c650
4. Reduced inputs for fuzzer,address,undefined,integer fe4760b23a
5. 
   maflcko commented at 2:05 pm on March 18, 2024: contributor

   Please add a link to the previous one, and the steps to reproduce, or a link to it.
6. 
   dergoegge commented at 2:09 pm on March 18, 2024: member

   Please add a link to the previous one, and the steps to reproduce, or a link to it.

   Done

7. 
   maflcko commented at 4:24 pm on March 18, 2024: contributor

   https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/monotree/aba9024c0cb50300/fe4760b23a848101/fuzz.coverage/index.html

   https://maflcko.github.io/b-c-cov/fuzz.coverage/index.html

8. 
   maflcko commented at 4:27 pm on March 18, 2024: contributor

   Looks like the runtime remains roughly the same? So maybe it is not worth it this time?
9. 
   dergoegge commented at 4:31 pm on March 18, 2024: member

   4.4GB vs 1.6GB on this PR with no coverage loss. I don’t see the benefit of keeping the redundant inputs around.
10. 
    maflcko commented at 4:35 pm on March 18, 2024: contributor

    Ok, fair enough.
11. 
    maflcko commented at 4:39 pm on March 18, 2024: contributor

    When I try to reproduce, I get subprocess timed out: Currently only libFuzzer is supported for the second step with the sanitizers.
12. 
    maflcko commented at 7:15 am on March 19, 2024: contributor

    Ok, I re-ran on a different machine and it somehow passed this time. Results:

    • About 100k deleted files

    0# git diff origin/main..fe4760b23a848101bf6e619bcaef80136951d9f4 --stat | tail -1
    1 113815 files changed, 574351 deletions(-)
    

    • Cross-diff of 25k files:

    0# git -c diff.renameLimit=13303 diff HEAD..fe4760b23a848101bf6e619bcaef80136951d9f4 --stat | tail -1
    1 24735 files changed, 9163 insertions(+), 285203 deletions(-)
    

13. 
    maflcko commented at 7:15 am on March 19, 2024: contributor

    lgtm
14. dergoegge merged this on Mar 19, 2024
15. dergoegge closed this on Mar 19, 2024

    ---

Contributors
dergoegge maflcko