Add eleven initial corpora and new seeds #194

1. 
   murchandamus commented at 2:08 pm on August 1, 2024: contributor

   Adds new seeds per same methodology as in #186 and adds initial corpora for the following eleven fuzz targets:

   • clusterlin_add_dependency
   • clusterlin_ancestor_finder
   • clusterlin_chunking
   • clusterlin_cluster_serialization
   • clusterlin_depgraph_serialization
   • clusterlin_linearization_chunking
   • clusterlin_linearize
   • crypter
   • crypto_aeadchacha20poly1305
   • crypto_fschacha20poly1305
   • p2p_handshake
2. Add initial cluster linearization corpora d5447a1e68
3. Add initial corpora for three new crypto targets

   - crypter
   - crypto_aeadchacha20poly1305
   - crypto_fschacha20poly1305

   f4b83a0cca
4. 
   murchandamus commented at 2:37 pm on August 1, 2024: contributor

   The number of lines added here seems off. Looking into what happened there.
5. 
   maflcko commented at 3:06 pm on August 1, 2024: contributor

   Would be nice to add p2p_handshake as well. Either here or in a follow-up. (I’ll do it later this month, when I submit my fuzz inputs, if no one beats me to it)
6. 
   murchandamus commented at 3:17 pm on August 1, 2024: contributor

   I checked and my version of Bitcoin Core did not have that fuzz target, then realized that it just got merged yesterday. I can add it tomorrow to this PR after fuzzing it the next day or so.
7. murchandamus force-pushed on Aug 1, 2024
8. murchandamus marked this as a draft on Aug 1, 2024
9. Add initial corpus for p2p_handshake c98fc19a89
10. Add freshly harvested fuzz seeds de62ef027c
11. murchandamus force-pushed on Aug 2, 2024
12. 
    murchandamus commented at 12:33 pm on August 2, 2024: contributor

    Still around 240,000 new seeds, so I guess I didn’t do it wrong the first time after all.
13. murchandamus marked this as ready for review on Aug 2, 2024
14. 
    dergoegge commented at 12:46 pm on August 2, 2024: member

    Still around 240,000 new seeds, so I guess I didn’t do it wrong the first time after all.

    0$ git diff --diff-filter=A --name-only origin/main..c98fc19a89d6c54a4b92d8e51a9b49d536d02ed2 | wc -l
    11496
    2$ git diff --diff-filter=A --name-only origin/main..murch/2024-08-add-seeds | wc -l
    319535
    

    Only 1.5k new seeds for the new harnesses and about 20k new seeds in total, which seems fine.

    I think the ~240k number refers to added lines (not sure how much sense that makes w.r.t fuzz inputs).

15. 
    murchandamus commented at 12:48 pm on August 2, 2024: contributor

    I see. I was assuming that any fuzz seed would be a single line
16. dergoegge approved
17. 
    dergoegge commented at 12:49 pm on August 2, 2024: member

    lgtm, waiting on CI
18. murchandamus renamed this:
    Add ten initial corpora and new seeds
    Add eleven initial corpora and new seeds
    on Aug 2, 2024
19. 
    maflcko commented at 2:07 pm on August 2, 2024: contributor

    You’ll have to revert the changes to that folder, or otherwise exclude the inputs.

    See https://github.com/bitcoin/bitcoin/issues/30514

    Maybe a temporary revert for just that folder, so that they can be added back afterwards easily?

20. Revert utxo_snapshot additions temporarily a3560339f2
21. 
    murchandamus commented at 2:26 pm on August 2, 2024: contributor

    I have reverted the addition of seeds for the utxo_snapshot target
22. 
    maflcko commented at 2:34 pm on August 2, 2024: contributor

    I’ve added a reminder to https://github.com/bitcoin/bitcoin/issues/30514#issuecomment-2265536803
23. dergoegge merged this on Aug 2, 2024
24. dergoegge closed this on Aug 2, 2024

    ---

Contributors
murchandamus maflcko dergoegge