ci: Turn persistent runners into GHA runners

maflcko commented at 1:34 pm on September 3, 2025: contributor

maflcko commented at 1:36 pm on September 3, 2025: contributor

Looks like this needs actions enabled. @fanquake

fanquake commented at 1:52 pm on September 3, 2025: member

Should be enabled.

maflcko closed this on Sep 3, 2025

maflcko reopened this on Sep 3, 2025

maflcko commented at 2:06 pm on September 3, 2025: contributor

Ah, I guess it needs to be merged, before it appears. Done in #237

m3dwards commented at 2:13 pm on September 3, 2025: none

Ah, I guess it needs to be merged, before it appears. Done in #237

I don’t believe this is the case. It might be that actions are disabled on PRs from forks?

ci: Turn persistent runners into GHA runners fd2bd02095

maflcko force-pushed on Sep 3, 2025

maflcko commented at 2:17 pm on September 3, 2025: contributor

The actions bitcoin/bitcoin/.github/actions/configure-environment@master, bitcoin/bitcoin/.github/actions/restore-caches@master, bitcoin/bitcoin/.github/actions/configure-docker@master, and bitcoin/bitcoin/.github/actions/save-caches@master are not allowed in bitcoin-core/qa-assets because all actions must be from a repository owned by bitcoin-core or match one of the patterns: actions/cache/restore@*, actions/cache/save@*, actions/cache@*, actions/checkout@*, actions/download-artifact@*, actions/github-script@*, actions/upload-artifact@*, cirruslabs/cache/restore@*, cirruslabs/cache/save@*, docker/setup-buildx-action@*, ilammy/msvc-dev-cmd@*.

I don’t think we need restrictions in this repo on actions? But if so, we’d need them to say bitcoin/bitcoin, or include that.

in .github/workflows/ci.yml:40 in fd2bd02095

36             runner: 'ubuntu-latest'
37+            timeout-minutes: 360
38+            file-env: './ci/test/00_setup_env_native_fuzz_with_msan.sh'
39+          - name: 'fuzz (valgrind)'
40+            runner: 'ubuntu-latest'
41+            timeout-minutes: 360

m3dwards commented at 2:33 pm on September 3, 2025:

A lot less than was set in .cirrus! I believe that this is the maximum for Github’s runners but if this ran on hosted runners it could be longer.

maflcko commented at 2:35 pm on September 3, 2025:

I don’t think there are hosted runners available right now in this repo, are there?

m3dwards commented at 3:34 pm on September 3, 2025:

No, but it could be nice to have? Especially if it’s one pool shared between this org and /bitcoin org. Not sure this is currently possible on Cirrus but have asked the question.

maflcko commented at 3:36 pm on September 3, 2025:

Ok. An alternative would be to purchase a second license with one runner (should be enough).

Yet another alternative could be warp-build or the pre-existing cirrus-ci (via cirrus.yml) with compute credits.

maflcko commented at 8:32 pm on September 3, 2025:

Looks like the CI passed, so I guess it can be merged now. A follow-up can deal with possible follow-ups

m3dwards commented at 1:31 pm on September 4, 2025:

Cirrus have confirmed that we can share runners between orgs but they need to be contacted directly as this is a manual step for them.

maflcko commented at 2:35 pm on September 4, 2025:

Cirrus have confirmed that we can share runners between orgs but they need to be contacted directly as this is a manual step for them.

Good to hear. I guess we can follow-up when there is need to. (I don’t plan to follow-up here for now)

fanquake commented at 2:57 pm on September 3, 2025: member

I don’t think we need restrictions in this repo on actions? But if so, we’d need them to say bitcoin/bitcoin, or include that.

Should be able to retry.

fanquake closed this on Sep 3, 2025

fanquake reopened this on Sep 3, 2025

maflcko commented at 8:34 pm on September 3, 2025: contributor

Would be good to get a review from either @m3dwards or @willcl-ark or someone else familiar with the CI , but otherwise I think this is rfm

m3dwards commented at 2:03 pm on September 4, 2025: none

Code review ACK: fd2bd020950bc7ef0758dc0cb8b80764038d6bf1

Would be nice to watch this after merging into master to check all the caches are working properly, especially because it reuses the cache actions from /bitcoin/bitcoin repo.

maflcko merged this on Sep 4, 2025

maflcko closed this on Sep 4, 2025

maflcko commented at 2:35 pm on September 4, 2025: contributor

Would be nice to watch this after merging into master to check all the caches are working properly, especially because it reuses the cache actions from /bitcoin/bitcoin repo.

It still fails with the same error as yesterday: https://github.com/bitcoin/bitcoin/issues/31965#issuecomment-3252448008

ci: Turn persistent runners into GHA runners #236