Add shebang to delete_nonreduced_fuzz_inputs.sh #268

pull ekzyis wants to merge 1 commits into bitcoin-core:main from ekzyis:delete-nonreduced-fuzz-inputs-shebang changing 1 files +1 −0
  1. ekzyis commented at 12:12 PM on March 26, 2026: none

    The script uses array features like readarray and the [@] syntax. Afaik, these require bash, see manual.

    While working on #266, I wasn't sure if I can assume bash and use syntax like REFS=("master").

    I created this PR to get this question out of the way.

  2. Add shebang to delete_nonreduced_fuzz_inputs.sh e8f063b07b
  3. ekzyis force-pushed on Mar 26, 2026
  4. maflcko commented at 12:26 PM on March 26, 2026: contributor

    While working on #266, I wasn't sure if I can assume bash and use syntax like REFS=("master").

    Thanks for working on this, and sorry for not reviewing that earlier, but I think Bash or Python are the wrong answer to long-running scripts, because inherently there will be an accidental typo (none vs None) or a type confusion string vs array (or syntax question like yours), which will only be discovered at run-time, possibly after waiting (wasting) hours.

    I think such long-running scripts should be written in a compiled language.

    So my recommendation would be to first re-write the existing Bash script to Rust. I wanted to do this last week, but I didn't get to it yet.

  5. maflcko commented at 12:28 PM on March 26, 2026: contributor

    edit: See https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/deterministic-unittest-coverage/src/main.rs for an example template for a main.rs that could be used as a style guide.

  6. ekzyis commented at 1:12 PM on March 26, 2026: none

    sorry for not reviewing that earlier

    No worries! I didn't expect any review, since it's still a draft.

    I think such long-running scripts should be written in a compiled language.

    Oh, yes, I agree! A compiled language would have helped with many conceptually small, yet time-consuming issues for shell reasons ("can I use arrays?", mv vs cp semantics if target is same file, syntax etc.)

    I'll see what I can do, but I might not get to it this week. So don't feel blocked by me, if you happen to have time.

  7. ekzyis closed this on Mar 26, 2026

  8. ekzyis deleted the branch on Mar 26, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/qa-assets. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 09:25 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me