ci: Fix broken qa assets dir injection #283

pull maflcko wants to merge 1 commits into bitcoin-core:main from maflcko:default changing 1 files +2 −2

maflcko commented at 5:07 AM on July 15, 2026: contributor

The upstream CI scratch directory was renamed, so the workflow must inject qa-assets into the new repo-relative path before the rsync step copies the checkout into BASE_ROOT_DIR.

maflcko commented at 5:09 AM on July 15, 2026: contributor

Otherwise, the repo will be cloned fresh from the default branch:

https://github.com/bitcoin-core/qa-assets/actions/runs/29358248731/job/87171305199?pr=282#step:8:1659

+ retry git clone --depth=1 https://github.com/bitcoin-core/qa-assets '/home/runner/work/_temp/ci/scratch_ ₿🧪_/qa-assets'
Cloning into '/home/runner/work/_temp/ci/scratch_ ₿🧪_/qa-assets'...
Updating files:   4% (9542/210986)
Updating files:   5% (10550/210986)
...
Updating files:  98% (207794/210986)
Updating files:  99% (208877/210986)

maflcko commented at 5:17 AM on July 15, 2026: contributor

Log is correct in this pull:

https://github.com/bitcoin-core/qa-assets/actions/runs/29410731707/job/87336928385?pr=283#step:8:424:

+ cd '/home/runner/work/_temp/ci/scratch_ ₿🧪_/qa-assets'
+ echo 'Using qa-assets repo from commit ...'
+ git log -1
Using qa-assets repo from commit ...
commit 2b2b84bfdf1a6f2736688864881fe872a250ed3e
Author: maflcko <6399679+maflcko@users.noreply.github.com>
Date:   Wed Jul 15 13:10:54 2026 +0200
    Merge 3779c20fa3c5d99cb9a4a716fbfab2dea3253c92 into b5878b68b0948fa192523e4959a064169a0f3d74

in .github/workflows/ci.yml:72 in 6dd8f58050
```
  67 | @@ -68,8 +68,8 @@ jobs:
  68 |  
  69 |        - name: CI script
  70 |          run: |
  71 | -          mkdir -p ./ci/scratch/qa-assets
  72 | -          mv ./qa-assets/{.git,fuzz_corpora} ./ci/scratch/qa-assets/
  73 | +          mkdir -p "./ci/scratch_ ₿🧪_/qa-assets"
  74 | +          mv ./qa-assets/.git ./qa-assets/fuzz_corpora "./ci/scratch_ ₿🧪_/qa-assets/"
```
ekzyis commented at 11:03 AM on July 15, 2026:

Just curious: Did you remove the brace expansion for better POSIX compliance?

maflcko commented at 11:13 AM on July 15, 2026:

Nice catch. I was trying to use a clanker to get the emoji formatting right ( :smiling_face_with_tear: ), but then it also changed the {}, which should work fine in Bash, which IIUC is used by GitHub.

I guess I should not have used a clanker here, but fixed up now.
ekzyis approved
ekzyis commented at 11:04 AM on July 15, 2026: contributor

ACK 6dd8f580500e54c54121f750a2a8530eab2fa76e

change was introduced in https://github.com/bitcoin/bitcoin/commit/fac6c4270dac566ebf274a5c18e30810a3da70f9
ci: Fix broken qa assets dir injection 3779c20fa3
maflcko force-pushed on Jul 15, 2026
maflcko merged this on Jul 20, 2026
maflcko closed this on Jul 20, 2026

Contributors

maflcko

ekzyis