Add PSBTv2 inputs to psbt #299

pull erickcestari wants to merge 1 commits into bitcoin-core:main from erickcestari:psbtv2-inputs changing 27 files +0 −0
  1. erickcestari commented at 1:40 PM on November 9, 2026: contributor

    The psbt corpus had no valid PSBTv2 input. A few inputs set PSBT_GLOBAL_VERSION = 2, but none got past the required global fields. So the v2 input/output maps, the v2 serializer and ComputeTimeLock were never reached.

    These inputs pair the valid BIP370 vectors from test/functional/data/rpc_psbt.json (v2+v2, v2+v0, v0+v2) in the harness's two-PSBT format. I merged them with test/fuzz/test_runner.py --m_dir (-set_cover_merge=1 -use_value_profile=0).

  2. Add PSBTv2 inputs to psbt 1260a44368
  3. erickcestari commented at 1:42 PM on November 10, 2026: contributor

    The CI error seems unrelated.

    Before (master 9c61fa724af7566eaa9f97ad23c637374ef469ea):

    psbt [#8122](/bitcoin-core-qa-assets/8122/)	DONE   cov: 27137 ft: 153544 corp: 4960/19Mb lim: 939504 exec/s: 80 rss: 744Mb
    

    After:

    psbt [#8149](/bitcoin-core-qa-assets/8149/)	DONE   cov: 29129 ft: 157323 corp: 4962/19Mb lim: 939504 exec/s: 135 rss: 830Mb
    
  4. maflcko commented at 1:46 PM on November 10, 2026: contributor

    Yes, it would be good if someone fixed it. I guess it is due the GitHub moving the default runners to Ubuntu 26.04? Maybe something like this would fix it:

    Subject: [PATCH] Reduce ASLR entropy for sanitizers in ci-mutations
    
    
    diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
    index bb512ed..97c06fd 100644
    --- a/.github/workflows/ci.yml
    +++ b/.github/workflows/ci.yml
    @@ -333,6 +333,10 @@ jobs:
    
     
    +      - name: Reduce ASLR entropy for sanitizers
    +        run: |
    +          sudo sysctl -w vm.mmap_rnd_bits=28
    +
    
  5. maflcko merged this on Nov 10, 2026
  6. maflcko closed this on Nov 10, 2026

  7. erickcestari commented at 1:55 PM on November 10, 2026: contributor

    Yes, it would be good if someone fixed it. I guess it is due the GitHub moving the default runners to Ubuntu 26.04? Maybe something like this would fix it:

    Subject: [PATCH] Reduce ASLR entropy for sanitizers in ci-mutations
    
    
    diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
    index bb512ed..97c06fd 100644
    --- a/.github/workflows/ci.yml
    +++ b/.github/workflows/ci.yml
    @@ -333,6 +333,10 @@ jobs:
    
     
    +      - name: Reduce ASLR entropy for sanitizers
    +        run: |
    +          sudo sysctl -w vm.mmap_rnd_bits=28
    +
    

    Right. I'll open a PR for it too.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/qa-assets. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-20 20:25 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me