doc: Fix upper bounds + cleanup in field_5x52_impl.h comment #1030

1. 
   robot-dreams commented at 5:26 pm on December 3, 2021: contributor

   When reviewing #816 I noticed the upper bounds in the comment at the top of field_5x52_impl.h were off by 1 (see fe_verify). This PR fixes the upper bounds and also cleans up the comment along the way.
2. 
   real-or-random commented at 4:37 pm on December 6, 2021: contributor

   Maybe this is a good opportunity to add a similar comment to the 10x26 implementation (or one that refers to the 5x52 comment).
3. robot-dreams force-pushed on Dec 6, 2021
4. real-or-random approved
5. 
   real-or-random commented at 9:51 am on December 22, 2021: contributor

   ACK bc7420fcba0c272d23650256e9fea3c12a3abbd3

   #816 reminded me that it may be a good idea to document the max magnitudes. (They’re checked in the code in fe_verify but that’s hard to discover if you’re not familiar with the code.) But I guess it’s not trivial, see #1028 (review)

6. 
   real-or-random commented at 11:56 am on December 22, 2021: contributor

   nit: The comment could also mention the order of the limbs. [0] is the least significant limb though that’s the natural choice.
7. 
   elichai commented at 12:59 pm on December 22, 2021: contributor

   ACK bc7420fcba0c272d23650256e9fea3c12a3abbd3 This is great! I spent a lot of time figuring out what are magnitudes and how the field arithmetic works exactly, so any doc improvements there are very welcome :)
8. doc: Fix upper bounds + cleanup in field_5x52_impl.h comment 58da5bd589
9. doc: Add comment to top of field_10x26_impl.h 1287786c7a
10. robot-dreams force-pushed on Dec 22, 2021
11. 
    real-or-random commented at 3:42 pm on December 22, 2021: contributor

    ACK 1287786c7a97eff520ffbd6b0d8b2f99dbfc6371
12. 
    real-or-random commented at 5:51 pm on December 22, 2021: contributor

    (I cancelled CI because this is blocking the other builds and the diff here is just in comments.)
13. real-or-random merged this on Dec 22, 2021
14. real-or-random closed this on Dec 22, 2021

    ---

15. jonasnick cross-referenced this on Jan 2, 2022 from issue Sync Upstream by jonasnick
16. real-or-random referenced this in commit 21e2d65b79 on Jan 5, 2022
17. dhruv referenced this in commit 6f7e395acc on Jan 26, 2022
18. hebasto referenced this in commit 065b6dbf9d on Jan 30, 2022
19. dhruv referenced this in commit 139d4b881e on Feb 1, 2022
20. fanquake referenced this in commit 8f8631d826 on Mar 17, 2022
21. fanquake referenced this in commit 4bb1d7e62a on Mar 17, 2022
22. fanquake referenced this in commit 465d05253a on Mar 30, 2022
23. stratospher referenced this in commit 4d5afc9767 on Apr 3, 2022
24. stratospher referenced this in commit 5b18493cfa on Apr 3, 2022
25. fanquake referenced this in commit afb7a6fe06 on Apr 6, 2022
26. gwillen referenced this in commit 35d6112a72 on May 25, 2022
27. patricklodder referenced this in commit 21badcf9d2 on Jul 25, 2022
28. patricklodder referenced this in commit 03002a9013 on Jul 28, 2022
29. janus referenced this in commit 3a0652a777 on Aug 4, 2022
30. str4d referenced this in commit 522190d5c3 on Apr 21, 2023
31. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
32. vmta referenced this in commit 8f03457eed on Jul 1, 2023

Contributors
robot-dreams real-or-random elichai