configure: Add hidden –enable-dev-mode to enable all the stuff #1079

1. 
   real-or-random commented at 8:31 pm on February 23, 2022: contributor

   Rework of #975, which I’m taking over with the permission of @elichai.

   See commit messages for some more rationale.

2. configure: Use canonical variable prefix _enable consistently 0d4226c051
3. configure: Remove redundant code that sets _enable variables

   These are set automatically by autoconf [1], and this has been the
   case in at least since 2.60, which is our minimum supported version.
   
   [1] https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Package-Options.html
   [2] https://www.gnu.org/software/autoconf/manual/autoconf-2.60/html_node/Package-Options.html

   fabd579dfa
4. real-or-random cross-referenced this on Feb 23, 2022 from issue Add a `--enable-dev-mode` to enable everything by elichai
5. 
   real-or-random commented at 8:33 pm on February 23, 2022: contributor

   I was wondering whether we should disable the benchmarks by default. I think normal users won’t need them and I suspect these were more interesting in the early days of the library.
6. real-or-random force-pushed on Feb 23, 2022
7. 
   sipa commented at 9:20 pm on February 23, 2022: contributor

   The benchmarks were actually disabled at some point by default, which led to a lot of wasted time for me because I forgot to compile benchmarks, and then ended up running with an old bench binary…
8. in build-aux/m4/bitcoin_secp.m4:47 in ca1b6e3659 outdated

   42+dnl SECP_SET_DEFAULT(VAR, default, default-dev-mode)
   43+dnl Set VAR to default or default-dev-mode, depending on whether dev mode is enabled
   44+AC_DEFUN([SECP_SET_DEFAULT], [
   45+  if test "${enable_dev_mode+set}" != set; then
   46+    AC_MSG_ERROR([[Set enable_dev_mode before calling SECP_SET_DEFAULT]])
   47+  fi 
   

   ---

   ---

   

   jonasnick commented at 9:05 pm on February 25, 2022:

   nit: trailing whitespace

   ---

   

   real-or-random commented at 9:30 am on February 26, 2022:

   fixed
9. 
   jonasnick commented at 9:07 pm on February 25, 2022: contributor

   ACK mod nit

   This is useful.

10. configure: Add hidden --enable-dev-mode to enable all the stuff

    Co-authored-by: Elichai Turkel <elichai.turkel@gmail.com>

    e0838d663d
11. real-or-random force-pushed on Feb 26, 2022
12. 
    jonasnick commented at 9:49 pm on February 26, 2022: contributor

    ACK e0838d663deba5a9663a0ad02bd7e4c563325c4d
13. 
    real-or-random commented at 10:58 am on February 27, 2022: contributor

    @elichai Want to review this?
14. 
    elichai commented at 12:17 pm on February 27, 2022: contributor

    tACK e0838d663deba5a9663a0ad02bd7e4c563325c4d

    Tested that this is actually hidden, that it enables all the modules as expected, and that it supports disabling specific modules

15. jonasnick merged this on Feb 27, 2022
16. jonasnick closed this on Feb 27, 2022

    ---

17. michaelfolkson cross-referenced this on Mar 16, 2022 from issue doc: Update README for --enable-dev-mode by michaelfolkson
18. fanquake referenced this in commit 8f8631d826 on Mar 17, 2022
19. fanquake referenced this in commit 4bb1d7e62a on Mar 17, 2022
20. fanquake referenced this in commit 4ef6189f8c on Mar 25, 2022
21. fanquake cross-referenced this on Mar 25, 2022 from issue build: remove unneeded configure $*val setting by fanquake
22. fanquake referenced this in commit 465d05253a on Mar 30, 2022
23. jonasnick cross-referenced this on Mar 30, 2022 from issue Upstream PRs 1064, 1049, 899, 1068, 1072, 1069, 1074, 1026, 1033, 748, 1079, 1088, 1090, 731, 1089, 995, 1094, 1093 by jonasnick
24. real-or-random referenced this in commit 6c0aecf72b on Apr 1, 2022
25. fanquake referenced this in commit afb7a6fe06 on Apr 6, 2022
26. gwillen referenced this in commit 35d6112a72 on May 25, 2022
27. patricklodder referenced this in commit 21badcf9d2 on Jul 25, 2022
28. patricklodder referenced this in commit 03002a9013 on Jul 28, 2022
29. janus referenced this in commit 3a0652a777 on Aug 4, 2022
30. str4d referenced this in commit 522190d5c3 on Apr 21, 2023
31. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
32. vmta referenced this in commit 8f03457eed on Jul 1, 2023

Contributors
real-or-random sipa jonasnick elichai