Add vcpkg installation instructions #1137

pull JonLiu1993 wants to merge 1 commits into bitcoin-core:master from JonLiu1993:vcpkg-instructions changing 1 files +13 −0
  1. JonLiu1993 commented at 8:03 am on August 25, 2022: none

    secp256k1 is available as a port in vcpkg, a C++ library manager that simplifies installation for secp256k1 and other project dependencies. Documenting the install process here will help users get started by providing a single set of commands to build secp256k1, ready to be included in their projects.

    We also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64) to keep a wide coverage for users.

    I’m a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library. :)

  2. Add vcpkg installation instructions db92849cef
  3. in README.md:122 in db92849cef
    115@@ -116,6 +116,19 @@ To create a CSV file for the benchmark result :
    116 
    117     $ ./bench_name | sed '2d;s/ \{1,\}//g' > bench_name.csv
    118 
    119+Building secp256k1 - Using vcpkg
    120+------------
    121+
    122+You can download and install secp256k1 using the [vcpkg](https://github.com/Microsoft/vcpkg) dependency manager:
    


    hebasto commented at 10:13 am on August 25, 2022:

    “Building” is not “download and install” :)

    This file contains no references to any package manager which provides the secp256k1 package. Seeing no reasons to make an exception for the vcpkg.

  4. real-or-random commented at 2:38 pm on August 25, 2022: contributor

    It’s really awesome to see that the library is packaged in various places (also some Linux distros) even though we have been lazy with releases. Thanks for these efforts, and we really hope this will be easier once we have a release out. (#1055) And feel free to ping us here whenever there’s an issue.

    On the other hand, the one build method that we currently officially support is the one currently described in the README, and yes, I don’t think it would make sense for us to have instructions for other build systems in our repo.

    But let me stress that it’s great that there is a vcpkg!

  5. sipa commented at 2:41 pm on August 25, 2022: contributor
    Echoing what @real-or-random said, but also: if we add cmake as build system (#1113), which presumably will be MSVC compatible, I would expect these instructions to shrink significantly?
  6. real-or-random commented at 2:52 pm on August 25, 2022: contributor
    @sipa vcpkg is somewhat agnostic of the compiler. It uses MSVC on Windows but gcc/g++ on Linux.
  7. hebasto commented at 12:42 pm on November 30, 2022: member

    if we add cmake as build system (#1113), which presumably will be MSVC compatible

    It is MSVC compatible :)

  8. real-or-random commented at 1:09 pm on December 2, 2022: contributor
    Closing this but please feel free to discuss further.
  9. real-or-random closed this on Dec 2, 2022


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 11:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me